fix(frontend): make WITH optional for user create and alter

[yezizp2012]

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title. Pointed out by @CharlieSYH , we should keep compatibility with PostgreSQL.

I tested this statement and it retuned an error "ERROR: sql parser error: Expected end of statement, found: PASSWORD":
CREATE USER u1 PASSWORD 's1234';
But this works: CREATE USER u1 WITH PASSWORD 's1234';

Seems that 'with' is not optional. Can you confirm on that?

Originally posted by @CharlieSYH in #3074 (comment)

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

• SQL commands, functions, and operators

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

[codecov]

Codecov Report

Merging #4414 (c92b6e8) into main (f103daf) will decrease coverage by 0.00%.
The diff coverage is 58.62%.

@@            Coverage Diff             @@
##             main    #4414      +/-   ##
==========================================
- Coverage   74.56%   74.56%   -0.01%     
==========================================
  Files         848      848              
  Lines      124163   124162       -1     
==========================================
- Hits        92582    92580       -2     
- Misses      31581    31582       +1     

Flag	Coverage Δ
rust	74.56% <58.62%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/sqlparser/src/ast/statement.rs	83.65% <58.62%> (-0.07%)	⬇️
src/meta/src/manager/id.rs	94.56% <0.00%> (-0.55%)	⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[CharlieSYH]

@yezizp2012
There is another behavior that differs from PG's:
In the current version of RW, password authentication is absent (login without password) during connection for user accounts created with PASSWORD NULL or PASSWORD '', or without the PASSWORD option. But PG treats empty string and null password differently:

If no password is specified, the password will be set to null and password authentication will always fail for that user. A null password can optionally be written explicitly as PASSWORD NULL. (https://www.postgresql.org/docs/current/sql-createrole.html)

In addition, is there any restrictions on the password?

[yezizp2012]

@yezizp2012 There is another behavior that differs from PG's: In the current version of RW, password authentication is absent (login without password) during connection for user accounts created with PASSWORD NULL or PASSWORD '', or without the PASSWORD option. But PG treats empty string and null password differently:

If no password is specified, the password will be set to null and password authentication will always fail for that user. A null password can optionally be written explicitly as PASSWORD NULL. (https://www.postgresql.org/docs/current/sql-createrole.html)

In addition, is there any restrictions on the password?

Yes, in current implementation of RW, PASSWORD NULL or PASSWORD '' will be treated exactly the same and user created in that way will login successfully without providing any password. Well, we'd better to keep compatibility with PG here. @cnissnzg would you please to take a look and fix this?

[cnissnzg]

LGTM