Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support explain sink #4430

Merged
merged 5 commits into from
Aug 4, 2022
Merged

feat: support explain sink #4430

merged 5 commits into from
Aug 4, 2022

Conversation

tabVersion
Copy link
Contributor

Signed-off-by: tabVersion [email protected]

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

as title, support stream sink in explain

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

None

@tabVersion
support explain sink
e9b636d 
Signed-off-by: tabVersion <[email protected]>
@tabVersion
format
2b2fec8 
Signed-off-by: tabVersion <[email protected]>
@codecov
Copy link

codecov bot commented Aug 4, 2022 •
edited
Loading

Codecov Report

Merging #4430 (da83bdf) into main (5fe991c) will decrease coverage by 0.00%.
The diff coverage is 90.62%.

@@            Coverage Diff             @@
##             main    #4430      +/-   ##
==========================================
- Coverage   74.54%   74.54%   -0.01%     
==========================================
  Files         848      848              
  Lines      124223   124226       +3     
==========================================
+ Hits        92601    92602       +1     
- Misses      31622    31624       +2
Flag Coverage Δ
rust 74.54% <90.62%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/handler/explain.rs 0.00% <0.00%> (ø)
src/frontend/src/handler/create_sink.rs 98.58% <93.54%> (-1.42%) ⬇️
src/meta/src/manager/id.rs 94.56% <0.00%> (+0.54%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

xiangjinwu
xiangjinwu approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@xiangjinwu xiangjinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Is it possible to add an e2e test to make sure it would not break later?

For example,
https://github.com/singularity-data/risingwave/blob/ae0388aeee470bb82b845e14df96220cf51e3d2a/e2e_test/ddl/table.slt#L5-L6
https://github.com/singularity-data/risingwave/blob/ae0388aeee470bb82b845e14df96220cf51e3d2a/e2e_test/batch/explain.slt#L4-L5

@mergify mergify bot merged commit 667ab5d into main Aug 4, 2022
@mergify mergify bot deleted the tab/explain-sink branch August 4, 2022 08:19
@hengm3467 hengm3467 added the user-facing-changes Contains changes that are visible to users label Aug 5, 2022
Little-Wallace added a commit to Little-Wallace/risingwave that referenced this pull request Aug 5, 2022
@Little-Wallace
Squashed commit of the following:
081277d 
commit 051cabf
Author: Bohan Zhang <[email protected]>
Date:   Fri Aug 5 15:47:13 2022 +0800

    refactor(sink): rename sink properties (risingwavelabs#4465)

    * rename sink properties

    Signed-off-by: tabVersion <[email protected]>

    * fix

    Signed-off-by: tabVersion <[email protected]>

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit a12a9a8
Author: Noel Kwan <[email protected]>
Date:   Fri Aug 5 15:08:10 2022 +0800

    feat(sqlsmith): generate extreme values (risingwavelabs#4345)

    * gen extreme for integrals

    * test parsing output

    * workaround

    * use extreme for float, temporal

    * Revert "test parsing output"

    This reverts commit 3d12856cb847727f4009aa6ce8f6033cc4d24393.

    * use i64 for min/max float

    * interim

    * mention workarounds

    * clean

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit ecdadce
Author: jon-chuang <[email protected]>
Date:   Fri Aug 5 14:56:16 2022 +0800

    fix(planner): Tumble can accept CTE as input (risingwavelabs#4450)

    fix tumble window

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit a232f2e
Author: congyi <[email protected]>
Date:   Fri Aug 5 14:40:44 2022 +0800

    refactor(row-serde): make row-serde directory clearer and update comments (risingwavelabs#4443)

    * refactor row-serde and update comments

    * rename

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit 9bd5db3
Author: Kexiang Wang <[email protected]>
Date:   Fri Aug 5 02:05:29 2022 -0400

    fix(meta): the ddl lock is not really locked (risingwavelabs#4461)

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit 56a1897
Author: Richard Chien <[email protected]>
Date:   Fri Aug 5 13:03:26 2022 +0800

    feat(optimizer): support stateless 2-phase agg optimization for append-only min/max (risingwavelabs#4433)

    * use stateless 2-phase agg optimization for append-only min/max aggs

    * update plan snapshots

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit 1ae6836
Author: sinemora <[email protected]>
Date:   Fri Aug 5 12:50:34 2022 +0800

    feat(frontend): add CREATEUSER and NOCREATEUSER option for user create/alter (risingwavelabs#4447)

    * initial

    * fix judge

    * fix

    * fix

    * fix pg_user

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit fc6b36d
Author: Liang <[email protected]>
Date:   Fri Aug 5 12:37:40 2022 +0800

    feat(meta): meta push initial hummock version into CN (risingwavelabs#4459)

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit 80beff0
Author: jon-chuang <[email protected]>
Date:   Fri Aug 5 12:25:08 2022 +0800

    fix(planner): DynamicFilter's LHS should follow upstream distribution (risingwavelabs#4452)

    fix

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit ce17661
Author: Kexiang Wang <[email protected]>
Date:   Fri Aug 5 00:11:47 2022 -0400

    feat(meta): add source info and stream source split info in get_clust… (risingwavelabs#4277)

    feat(meta): add source info and stream source split info in get_cluster_info

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit f97a836
Author: jon-chuang <[email protected]>
Date:   Fri Aug 5 11:58:34 2022 +0800

    fix(planner): Pullup predicates in `LogicalScan` into `BatchLookupJoin`  (risingwavelabs#4453)

    fix

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit 9b259bc
Author: zwang28 <[email protected]>
Date:   Fri Aug 5 11:13:33 2022 +0800

    feat(meta): piggyback extra info in heartbeat RPC. (risingwavelabs#4435)

    * feat(meta): piggyback extra info in heartbeat RPC.

    * collect extra_info_sources before start heartbeat task

commit bf1eb44
Author: Croxx <[email protected]>
Date:   Thu Aug 4 18:53:42 2022 +0800

    fix: build on non-linux target (risingwavelabs#4448)

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit fe9cc4d
Author: Wallace <[email protected]>
Date:   Thu Aug 4 18:40:30 2022 +0800

    fix(cache):  clean pending request immediately when future cancel (risingwavelabs#4422)

    * fix future drop

    Signed-off-by: Little-Wallace <[email protected]>

    * clean pending request

    Signed-off-by: Little-Wallace <[email protected]>

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit b016a50
Author: zwang28 <[email protected]>
Date:   Thu Aug 4 18:27:22 2022 +0800

    refactor(common): add rpc client pool (risingwavelabs#4410)

    refactor(common): add rpc client pool trait

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit 934350c
Author: Huangjw <[email protected]>
Date:   Thu Aug 4 18:14:46 2022 +0800

    fix(ci): fix main ci build timeout (risingwavelabs#4444)

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit 96c8ea6
Author: ZENOTME <[email protected]>
Date:   Thu Aug 4 18:02:13 2022 +0800

    chore: support more query statement in extended query mode (risingwavelabs#4441)

    * * support more query statement('select','describe','values','show','with')
    * support returning error when can't find a statement or portal  rather than panic
    * modify some filed name of message

    * * add comment
    * unify some name

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit 2f98f9c
Author: Croxx <[email protected]>
Date:   Thu Aug 4 17:49:32 2022 +0800

    feat(cache): introduce tiered cache abstraction (risingwavelabs#4406)

    * feat(cache): introduce tiered cache abstraction

    * refactor write batch design

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit 314473c
Author: Runji Wang <[email protected]>
Date:   Thu Aug 4 17:32:21 2022 +0800

    feat(test): make simulation test deterministic! (risingwavelabs#4336)

    * 3 compute nodes

    Signed-off-by: Runji Wang <[email protected]>

    * revert `madsim::time::Instant` to std's

    Signed-off-by: Runji Wang <[email protected]>

    * make `RowIdGenerator` async

    Signed-off-by: Runji Wang <[email protected]>

    * switch to nextest

    Signed-off-by: Runji Wang <[email protected]>

    * fix simulated e2e test

    Signed-off-by: Runji Wang <[email protected]>

    * update madsim to v0.2.0-alpha.6 and tonic to v0.8

    now additional system protoc is required.

    Signed-off-by: Runji Wang <[email protected]>

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit 2d8ef9e
Author: August <[email protected]>
Date:   Thu Aug 4 17:10:26 2022 +0800

    fix: fix observer version check and add sync in compute/compactor node (risingwavelabs#4439)

    * fix: fix observer version check for init notification

    * add sync

    * fix sqlsmith

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit aff3352
Author: Li0k <[email protected]>
Date:   Thu Aug 4 16:57:32 2022 +0800

    chore(risedev): unify clippy between risedev c and pre-unit-test.sh (risingwavelabs#4436)

    * chore(risedev): unify clippy between risedev c and pre-unit-test.sh

    * fix(frontend): fix clippy

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit bffc66b
Author: Huangjw <[email protected]>
Date:   Thu Aug 4 16:45:08 2022 +0800

    chore(ci): remove repeated ci steps (risingwavelabs#4423)

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit 7a0a99d
Author: xxchan <[email protected]>
Date:   Thu Aug 4 11:32:21 2022 +0300

    chore: update comments for dispatcher (risingwavelabs#4413)

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit 667ab5d
Author: Bohan Zhang <[email protected]>
Date:   Thu Aug 4 16:19:20 2022 +0800

    feat: support explain sink (risingwavelabs#4430)

    * support explain sink

    Signed-off-by: tabVersion <[email protected]>

    * format

    Signed-off-by: tabVersion <[email protected]>

    * add ci for explain sink

    Signed-off-by: tabVersion <[email protected]>

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit 5fe991c
Author: xxchan <[email protected]>
Date:   Thu Aug 4 11:06:50 2022 +0300

    fix: use SomeShard as the distribution of batch scan (risingwavelabs#4420)

    * fix: use SomeShard as the distribution of batch scan

    * drop

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit 2d42495
Author: Li0k <[email protected]>
Date:   Thu Aug 4 15:29:15 2022 +0800

    fix(frontend): fix table option for internal table (risingwavelabs#4416)

    * feat(storage): save properties in ctx and remove support for source

    * feat(frontend): support properties for agg_plan and hash_join_plan

    * fix(frontend): assign properties for stream_materialize_view::create and add some limit

    * chore(front): remove redundant code

    * fix(frontend): fix clippy

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit ae0388a
Author: August <[email protected]>
Date:   Thu Aug 4 15:15:52 2022 +0800

    fix(frontend): make WITH optional for user create and alter (risingwavelabs#4414)

    fix: make WITH optional for user create and alter

    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit f103daf
Author: xiangjinwu <[email protected]>
Date:   Thu Aug 4 14:59:50 2022 +0800

    fix(binder): allow `Clone` for `expr::Subquery` as part of CTE (risingwavelabs#4424)

    fix(binder): allow Clone for expr::Subquery as part of CTE

commit ea36e52
Author: Lee Zong Yu <[email protected]>
Date:   Thu Aug 4 13:02:45 2022 +0800

    feat(sqlsmith): Enable gen_agg but workaround distinct agg (risingwavelabs#4421)

    Enable gen_agg

commit cc4224d
Author: Noel Kwan <[email protected]>
Date:   Thu Aug 4 11:44:17 2022 +0800

    feat(sqlsmith): generate explicit type castings (risingwavelabs#4419)

    * gen cast map

    * gen cast

    * dump cast table

    * gen explicit cast expr

    * avoid varchar casts

    * fix review comments

Signed-off-by: Little-Wallace <[email protected]>
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
@tabVersion @mergify @nasnoisaac
feat: support explain sink (risingwavelabs#4430)
69679e2 
* support explain sink

Signed-off-by: tabVersion <[email protected]>

* format

Signed-off-by: tabVersion <[email protected]>

* add ci for explain sink

Signed-off-by: tabVersion <[email protected]>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangjinwu xiangjinwu xiangjinwu approved these changes

@nanderstabel nanderstabel Awaiting requested review from nanderstabel

Assignees
No one assigned
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tabVersion @xiangjinwu @hengm3467