Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ctl): support list key-value pairs #782

Merged
merged 1 commit into from
Mar 9, 2022
Merged

feat(ctl): support list key-value pairs #782

merged 1 commit into from
Mar 9, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Mar 9, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title

cargo run --bin risectl -- list-kv

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

ref #721
ref #625

@skyzh skyzh requested review from twocode and hzxa21 March 9, 2022 06:33
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #782 (304d34e) into main (7048721) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #782      +/-   ##
============================================
- Coverage     72.35%   72.31%   -0.05%     
  Complexity     2759     2759              
============================================
  Files           915      917       +2     
  Lines         53068    53113      +45     
  Branches       1783     1783              
============================================
+ Hits          38397    38407      +10     
- Misses        13779    13814      +35     
  Partials        892      892              
Flag Coverage Δ
java 61.17% <ø> (ø)
rust 77.00% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/ctl/src/cmd_impl/list_kv.rs 0.00% <0.00%> (ø)
rust/ctl/src/common/hummock_service.rs 0.00% <0.00%> (ø)
rust/ctl/src/common/meta_service.rs 0.00% <0.00%> (ø)
rust/ctl/src/lib.rs 0.00% <0.00%> (ø)
rust/frontend/src/binder/bind_context.rs 60.00% <0.00%> (-40.00%) ⬇️
rust/frontend/src/binder/table_ref.rs 84.09% <0.00%> (-0.76%) ⬇️
rust/meta/src/hummock/compaction.rs 81.43% <0.00%> (-0.60%) ⬇️
rust/bench/ss_bench/main.rs 0.00% <0.00%> (ø)
rust/bench/ss_bench/utils/display_stat.rs
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7048721...304d34e. Read the comment docs.

@skyzh skyzh merged commit 5509486 into main Mar 9, 2022
@skyzh skyzh deleted the skyzh/ctl-scan-key branch March 9, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants