gittip: Use Meson's capture: true for Python 3.6 compatibility
#2869
Conversation
kazarmy
requested review from
ret2libc,
thestr4ng3r,
wargio and
XVilka
as code owners
| called = subprocess.run(args, check=True, capture_output=True) | ||
| with open("gittip", "w", encoding="utf8") as f: | ||
| f.write(called.stdout.decode("utf8").strip()) | ||
| called = subprocess.run(args, check=True) |
There was a problem hiding this comment.
This is wrong, and using capture: true in Meson is bad -- it causes this python script to be run by meson --internal exe, which imports lots of stuff and is very slow and obscures the command line.
You don't need to throw the baby out with the bathwater. capture_output is python 3.7, sure, but it's also literally an alias for stdout=subprocess.PIPE, stderr=subprocess.PIPE and it's extremely easy to make that work with python 3.6.
There was a problem hiding this comment.
Okay #2873 ... Using stdout=subprocess.PIPE changes the behavior of sys/meson_git_wrapper.py away from expected behavior, but hopefully this divergence is only temporary.
There was a problem hiding this comment.
Great. Happy to help. :)
Capture exists solely for the benefit of tools that don't support specifying the output file and usually cannot be modified as they are external processing tools rather than internal helper scripts, so you don't really have a choice.
Your checklist for this pull request
Detailed description
This pr fixes the following problem (https://github.com/rizinorg/rizin/runs/7665608906?check_suite_focus=true#step:7:814):
and reverts
sys/meson_git_wrapper.pyso any lost functionality should also be restored.Test plan
The fix makes sense. All builds are green.
Closing issues
...