Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gittip: Use subprocess.PIPE instead for Python 3.6 compatibility #2873

Merged
merged 10 commits into from
Aug 6, 2022

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Aug 5, 2022

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

As per #2869 (comment), this pr uses subprocess.PIPE inside sys/meson_git_wrapper.py for Python 3.6 compatibility instead, and yes the speedup is significant.

Test plan

The change is functionally equivalent. All builds are green.

Closing issues

...

@kazarmy kazarmy marked this pull request as draft August 5, 2022 15:48
@kazarmy kazarmy marked this pull request as ready for review August 6, 2022 01:04
@kazarmy kazarmy merged commit dc8cd44 into rizinorg:dev Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants