Capstone@next TriCore

[imbillow]

REBASE ONLY

Your checklist for this pull request

• I've read the guidelines for contributing to this repository
• I made sure to follow the project's coding style
• I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
• I've added tests that prove my fix is effective or that my feature works (if possible)
• I've updated the rizin book with the relevant information (if needed)

Detailed description

• Update TriCore asm plugin
• Improve TriCore analysis plugin

Test plan

CI is green

Closing issues

Partially addresses #2704
Closes #3540

[XVilka]

@imbillow you could temporarily disable it in your PR, and address them later

[imbillow]

I found that there are some variables with different names and types in the DWARF information but with the same location. What I do in the code is to let it do not overwrite the arguments of function at least.

[XVilka]

I found that there are some variables with different names and types in the DWARF information but with the same location. What I do in the code is to let it do not overwrite the arguments of function at least.

Interesting. This is better be addressed during the DWARF 5 implementation though. Since the only issue in this PR is the System Z, could you please extract variable changes (after addressing my feedback first) into a separate PR again, so that we could merge them again and rebase tricore branches?

[XVilka]

One more nitpick @imbillow, on the same file erika3app.elf:

[0x80000020]> afv @ dbg.osEE_alarm_get
var OsEE_CounterDB *p_counter_db @ a12
var OsEE_TriggerCB * const  p_trigger_cb @ a13
var OsEE_spin_lock *p_lock @ a15
var OsEE_CDB * const  p_cdb @ a2
arg OsEE_AlarmDB *p_alarm_db @ a4
var CoreIdType counter_core_id @ d10
arg TickType *p_tick @ d11
var TickType delta @ d15
var TickType when @ d2
var StatusType ev @ d8

Note the * const and then two spaces before p_cdb. I think it should be var OsEE_CDB *const p_cdb @ a2 instead, and for other similar cases.

Please also rebase on top of the latest dev

[XVilka]

Why do you try to fix it as the endianness of the Tricore? It's the endianness of the host. I think the bug is somewhere in the Capstone, and you could try just running capstone tests for Tricore on the System Z VM, I bet it will show the problem

[imbillow]

Why do you try to fix it as the endianness of the Tricore? It's the endianness of the host. I think the bug is somewhere in the Capstone, and you could try just running capstone tests for Tricore on the System Z VM, I bet it will show the problem

Just trying it out.

I've actually tried debug in a s390x qemu Ubuntu22.04 VM, but found that gdb/lldb doesn't seem to debug properly.

I'll do more experimentation when I can operate my pc later.

[XVilka]

Looks green now; well done. Please rearrange commits, and extract non-tricore part into a separate PR. Once its merged, we can rebase and merge this one too.

[XVilka]

@imbillow you forgot this

[XVilka]

And this

[imbillow]

#3561

I will fix these places in a new PR

[XVilka]

@imbillow merged the PR: 6f3969f

Please rebase capstone-ng and this PR on top of dev, then we can finally merge this.