Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move inheritance from ModelWithFile to ICubGazeboABC #342

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Move inheritance from ModelWithFile to ICubGazeboABC #342

merged 1 commit into from
Apr 29, 2021

Conversation

diegoferigo
Copy link
Collaborator

Minor edit of the ICubGazeboABC abstract class. In this way, both ICubGazebo and ICubGazeboSimpleCollisions inherit from ModelWithFile. Before this PR, inheritance was not present for ICubGazeboSimpleCollisions even though it had the get_model_file method.

@diegoferigo diegoferigo requested a review from traversaro April 29, 2021 13:47
@diegoferigo diegoferigo self-assigned this Apr 29, 2021
@diegoferigo diegoferigo changed the title Move inheritance from ModelWithFile to ICubGazeboABC Move inheritance from ModelWithFile to ICubGazeboABC Apr 29, 2021
@diegoferigo diegoferigo merged commit c6d6767 into devel Apr 29, 2021
@diegoferigo diegoferigo deleted the fix/move_model_with_file_inheritance branch April 29, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

Assignees

@diegoferigo diegoferigo

Labels
complexity::trivial component::gym_ignition_environments pr::resolution::merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegoferigo @traversaro