PMC piezo driver: update wave tables - shrink in range 2V to 44V #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PMC piezo driver currently uses:
PIEZO_MINVOLTAGE
toPIEZO_MAXVOLTAGE
in order to brake and to go in freewheel state (which I don't know whether really works with those motors), and forcedPIEZO_MINVOLTAGE
in case of overcurrent.Currently the tables were in range 128 to 65407 (DAC codes) while the
PIEZO_MINVOLTAGE
andPIEZO_MAXVOLTAGE
lead to DAC codes in range 2760 to 60707.This is clearly visible in this screenshot
According to G.Z:
PIEZO_MINVOLTAGE
andPIEZO_MAXVOLTAGE
constantsThis lead to the conclusion that the wave tables should be recalculated to fit in the 2760 to 60707 range.
This PR updateds the tables and the generation script according to this.
The outcome is visible in the following screenshot. NOTE: It has been not tested on real HW.