Fix log subscriber unsubscriptions #275
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a bug in ActionView#public_methods(false) that makes it not returning subscription methods. Using #patterns the log subscribed is asked directly for its supported event names. This becomes evident when using Lograge with a lower log level where rendering logs render-time for each template/partial.
Using Lograge in development or with a lower log-level will make AR logs to be printed.
|
Do you have a reference the bug you mentioned? |
Sorry for the delay, I tried to replicate on a fresh app that I could share, but I couldn't. Anyway the app where I'm observing the bug is ruby 2.3.7, rails 5.1, solidus 2.4 and the usual ton of gems. I can say though that I noticed that the problem is wider, for example I'm seeing messages from ActiveModel::Serializer in production (see screenshot below). So the problem is more widespread and I think would be useful to have a general way of unsubscribing from noisy components, defaulting to the current environment.
NOTE: I'll wait for instructions on how to proceed before fixing the specs and/or revising the PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in ActionView#public_methods(false) that makes it not returning
subscription methods. Using #patterns the log subscribed is asked directly for
its supported event names.
This becomes evident when using Lograge with a lower log level where rendering
logs render-time for each template/partial.
Also added ActiveRecord to the mix that is very noisy when using lograge in development.