Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log subscriber unsubscriptions #275

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix log subscriber unsubscriptions #275

wants to merge 2 commits into from

Commits on Jan 23, 2019

  1. Use LogSubscriber#patterns to fetch events names 

    There's a bug in ActionView#public_methods(false) that makes it not returning
subscription methods. Using #patterns the log subscribed is asked directly for
its supported event names.

This becomes evident when using Lograge with a lower log level where rendering
logs render-time for each template/partial.
    @elia
    elia committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    e9732c5 View commit details
    Browse the repository at this point in the history

  2. Unsubscribe from ActiveRecord logs too 

    Using Lograge in development or with a lower log-level will make AR logs to be
printed.
    @elia
    elia committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    d8f03c5 View commit details
    Browse the repository at this point in the history