Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Fatal error with release 2.7.0 #119

Closed
therealgilles opened this issue Sep 13, 2023 · 2 comments · Fixed by #120
Closed

PHP Fatal error with release 2.7.0 #119

therealgilles opened this issue Sep 13, 2023 · 2 comments · Fixed by #120

Comments

@therealgilles
Copy link

therealgilles commented Sep 13, 2023 •
edited
Loading

On the one hand, very happy to see a new release. On the other hand, this:

PHP Fatal error:  Uncaught TypeError: Cannot assign string to property Rollbar\Config::$sendMessageTrace of type bool in .../wp-content/plugins/rollbar/php8/vendor/rollbar/rollbar/src/Config.php:692
@therealgilles therealgilles changed the title PHP FataL error with release 2.7.0 PHP Fatal error with release 2.7.0 Sep 13, 2023
@brianr
Copy link
Member

brianr commented Sep 13, 2023

Thank you, @therealgilles . We'll take a look at this.

aaronjorbin added a commit to aaronjorbin/rollbar-php-wordpress that referenced this issue Sep 13, 2023
@aaronjorbin
Cast "1" and "0" as booleans when they are expected as booleans.
badf31f 
Rollbar/WordPress/UI creates checkboxes for booleans and stores the state as "1" and "0". The PHP8 version of https://github.com/rollbar/rollbar-php expects actual booleans. this updates the config builder to convert "1" and "0" into TRUE and FALSE.

Fixes: rollbar#119
@aaronjorbin aaronjorbin mentioned this issue Sep 13, 2023
Merged
9 tasks
@aaronjorbin aaronjorbin mentioned this issue Sep 13, 2023
Merged
@aaronjorbin
Copy link
Collaborator

Hi @therealgilles, thanks for the report and sorry for the issue. I've fixed this and just pushed the update to https://wordpress.org/plugins/rollbar/ (as well as tagged here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cast "1" and "0" as booleans when they are expected as booleans. aaronjorbin/rollbar-php-wordpress
3 participants
@brianr @aaronjorbin @therealgilles