Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast "1" and "0" as booleans when they are expected as booleans. #120

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

aaronjorbin
Copy link
Collaborator

Rollbar/WordPress/UI creates checkboxes for booleans and stores the state as "1" and "0". The PHP8 version of https://github.com/rollbar/rollbar-php expects actual booleans. this updates the config builder to convert "1" and "0" into TRUE and FALSE.

Fixes: #119

Description of the change

Adds support to the boolean check in buildPHPConfig for "1" and "0".

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached

Rollbar/WordPress/UI creates checkboxes for booleans and stores the state as "1" and "0". The PHP8 version of https://github.com/rollbar/rollbar-php expects actual booleans. this updates the config builder to convert "1" and "0" into TRUE and FALSE.

Fixes: rollbar#119
@aaronjorbin aaronjorbin merged commit 00b403e into rollbar:master Sep 13, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP Fatal error with release 2.7.0
2 participants