changes between 1.15.7 (Noetic) and 1.14.5 for backporting into Melodic #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current description comments after members start with '//!', resulting in broken documentation showing the descriptions on the wrong members. Change that to '//!<' according to doxygen documentation to have descriptions correctly associated with the respective members.
…1929) Signed-off-by: Tomoya.Fujita <[email protected]>
pycrypto used to be installed through rosbag. This was dropped in #1609 making roslaunch on remote hosts fail.
…sh is not installed (#1948) * Avoid infinite recursion This avoids infinite recusion that happens if tab completion is attempted but rosbash is not installed. Signed-off-by: Shane Loretz<[email protected]> Signed-off-by: Shane Loretz <[email protected]> * remove empty line Co-authored-by: Dirk Thomas <[email protected]>
…ment (#1952) Bag migration failed with follwoing errors: NameError: global name 'connection_header' is not defined This change fixes that by using local name conn_header
there is a case that accessing a connection object which was destroyed by ConnectionManager and TransportSubscriberLink/TransportPublicationLink while getting a close event in pollset to call Connection::drop. Signed-off-by: Barry Xu <[email protected]>
dirk-thomas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following list of changes has been integrated into ros_comm 1.15.7 (Noetic) since the last Melodic release (1.14.5).
Backported: (these changes are part of this PR)
Fix brief description comments after members (Fix brief description comments after members #1920)
Remove extra \n in ROS_DEBUG (Remove extra \n in ROS_DEBUG. #1925)
Check if enough FDs are free, instead counting the total free FDs (Check if enough FDs are free, instead counting the total free FDs. #1929)
use undefined dynamic_lookup on OSX) (Fix #923 (use undefined dynamic_lookup on OSX) #1923)
remove pycrypto import (not used) ([roslaunch] remove pycrypto import (not used) #1922)
Sort printed nodes by namespace alphabetically (Sort printed nodes by namespace alphabetically #1934)
Avoid infinite recursion in rosrun tab completion when rosbash is not installed ([noetic] Avoid infinite recursion in rosrun tab completion when rosbash is not installed #1948)
Fix bag migration failures caused by typo in connection_header assignment (Fix bag migration failures caused by typo in connection_header assignment #1952)
Fix a bug that using a destroyed connection object (Fix a bug that using a destroyed connection object. #1950)
fix NameError in launch error handling (fix NameError in launch error handling #1965)
Not backported:
roslaunch-check: Search dir recursively (roslaunch-check: Search dir recursively #1914)
clear message queue on simtime jumping back (clear message queue on simtime jumping back #1518)
Fix negative numbers in ros statistics (Fix negative numbers in ros statistics #1531)
Fix bare pointer in topic_tools::ShapeShifter (Fix bare pointer in topic_tools::ShapeShifter #1722)
Add rosout integration test (Add rosout integration test #1924)
Multiple latched publishers per process on the same topic (roscpp: Multiple latched publishers per process on the same topic (fix #146) #1544)
Add option to repeat latched messages at the start of bag splits (Add option to repeat latched messages at the start of bag splits #1850)
roslaunch: Allow passing _TIMEOUT_SIGINT and _TIMEOUT_SIGTERM as parameters (roslaunch: Allow passing _TIMEOUT_SIGINT and _TIMEOUT_SIGTERM as parameters #1937)
Fix bug that connection drop signal related funtion throw a bad_weak (Fix bug that connection drop signal related funtion throw a bad_weak … #1940)
check if async socket connect is success or failure before read and write in TransportT (check if async socket connect is success or failure before read and write in TransportT #1954)
Fixing Windows build break ([noetic] Fixing Windows build break. #1961)