Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log*_throttle with sim time #2044

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Fix log*_throttle with sim time #2044

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cddd336
Fix log*_throttle with sim time
salihmarangoz Sep 12, 2020
ea05109
fixed a bug where client loses a log message when rostime goes backward
salihmarangoz Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clients/rospy/src/rospy/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,9 @@ def __call__(self, caller_id, period):
(now - last_logging_time) > rospy.Duration(period)):
self.last_logging_time_table[caller_id] = now
return True
elif (last_logging_time > now):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: please remove the parenthesis.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

self.last_logging_time_table = {}
dirk-thomas marked this conversation as resolved.
Show resolved Hide resolved
return True
return False


Expand Down