Fix log*_throttle with sim time #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When log*_throttle is used with bags or a simulation, logging stops. Solved this problem with resetting logging_time_table when ros time moved backward
dirk-thomas
reviewed
Sep 17, 2020
clients/rospy/src/rospy/core.py
Outdated
| @@ -223,6 +223,9 @@ def __call__(self, caller_id, period): | |||
| (now - last_logging_time) > rospy.Duration(period)): | |||
| self.last_logging_time_table[caller_id] = now | |||
| return True | |||
| elif (last_logging_time > now): | |||
There was a problem hiding this comment.
Nitpick: please remove the parenthesis.
removed paranthesis fixed a bug where client loses a log message when rostime goes backward
|
It should be ok now |
|
Thanks for the patch. |
jacobperron
pushed a commit
that referenced
this pull request
Oct 16, 2020
* Fix log*_throttle with sim time When log*_throttle is used with bags or a simulation, logging stops. Solved this problem with resetting logging_time_table when ros time moved backward * fixed a bug where client loses a log message when rostime goes backward removed paranthesis fixed a bug where client loses a log message when rostime goes backward
jacobperron
pushed a commit
that referenced
this pull request
Oct 22, 2020
* Fix log*_throttle with sim time When log*_throttle is used with bags or a simulation, logging stops. Solved this problem with resetting logging_time_table when ros time moved backward * fixed a bug where client loses a log message when rostime goes backward removed paranthesis fixed a bug where client loses a log message when rostime goes backward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When log*_throttle is used with bags or a simulation, logging stops when bag/simulation restarts. Solved this problem with resetting logging_time_table when ros time moved backward.
Testing code: