Add an option for to not generate a database platform code

Resolve doctrine#781
roukmoute · Jan 17, 2019 · da223d4 · da223d4
1 parent 1d6ebbf
commit da223d4
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 4 deletions.
diff --git a/lib/Doctrine/Migrations/Generator/DiffGenerator.php b/lib/Doctrine/Migrations/Generator/DiffGenerator.php
@@ -63,7 +63,8 @@ public function generate(
         string $versionNumber,
         ?string $filterExpression,
         bool $formatted = false,
-        int $lineLength = 120
+        int $lineLength = 120,
+        bool $checkDbPlatorm = true
     ) : string {
         if ($filterExpression !== null) {
             $this->dbalConfiguration->setFilterSchemaAssetsExpression($filterExpression);
@@ -76,13 +77,15 @@ public function generate(
         $up = $this->migrationSqlGenerator->generate(
             $fromSchema->getMigrateToSql($toSchema, $this->platform),
             $formatted,
-            $lineLength
+            $lineLength,
+            $checkDbPlatorm
         );
 
         $down = $this->migrationSqlGenerator->generate(
             $fromSchema->getMigrateFromSql($toSchema, $this->platform),
             $formatted,
-            $lineLength
+            $lineLength,
+            $checkDbPlatorm
         );
 
         if ($up === '' && $down === '') {

diff --git a/lib/Doctrine/Migrations/Tools/Console/Command/DiffCommand.php b/lib/Doctrine/Migrations/Tools/Console/Command/DiffCommand.php
@@ -8,6 +8,8 @@
 use Doctrine\Migrations\Provider\OrmSchemaProvider;
 use Doctrine\Migrations\Provider\SchemaProviderInterface;
 use Doctrine\Migrations\Tools\Console\Exception\InvalidOptionUsage;
+use const FILTER_VALIDATE_BOOLEAN;
+use function filter_var;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -72,6 +74,13 @@ protected function configure() : void
                 InputOption::VALUE_OPTIONAL,
                 'Max line length of unformatted lines.',
                 120
+            )
+            ->addOption(
+                'check-database-platform',
+                null,
+                InputOption::VALUE_OPTIONAL,
+                'Check Database Platform to the generated code.',
+                true
             );
     }
 
@@ -85,6 +94,7 @@ public function execute(
         $filterExpression = $input->getOption('filter-expression') ?? null;
         $formatted        = (bool) $input->getOption('formatted');
         $lineLength       = (int) $input->getOption('line-length');
+        $checkDbPlatorm   = filter_var($input->getOption('check-database-platform'), FILTER_VALIDATE_BOOLEAN);
 
         if ($formatted) {
             if (! class_exists('SqlFormatter')) {
@@ -100,7 +110,8 @@ public function execute(
             $versionNumber,
             $filterExpression,
             $formatted,
-            $lineLength
+            $lineLength,
+            $checkDbPlatorm
         );
 
         $editorCommand = $input->getOption('editor-cmd');

diff --git a/tests/Doctrine/Migrations/Tests/Tools/Console/Command/DiffCommandTest.php b/tests/Doctrine/Migrations/Tests/Tools/Console/Command/DiffCommandTest.php
@@ -48,6 +48,11 @@ public function testExecute() : void
             ->willReturn(80);
 
         $input->expects(self::at(3))
+            ->method('getOption')
+            ->with('check-database-platform')
+            ->willReturn(true);
+
+        $input->expects(self::at(4))
             ->method('getOption')
             ->with('editor-cmd')
             ->willReturn('mate');