feat: support tailwindcss v3.1.x and v3.2.y #21
+242
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid `rslib build` failed due to tailwindcss types not correct.
colinaaa
force-pushed
the
colin/cjs-tailwind
branch
from
5e14110
to
0e05c6a
Compare
Also, change version to - 3.1.0 - 3.3.0 - latest
This shoule be covered by 'latest'
colinaaa
changed the title
chenjiahan
reviewed
Nov 26, 2024
|
|
||
| async #resolveTailwindCSSVersion(): Promise<string> { | ||
| const require = createRequire(import.meta.url); | ||
| const pkgPath = require.resolve('tailwindcss/package.json'); |
There was a problem hiding this comment.
require.resolve('tailwindcss/package.json') may misjudge in monorepo
| // | ||
| // In this case, we provide an ESM configuration to support both ESM and CJS. | ||
| return [ | ||
| 'tailwind.config.mjs', |
There was a problem hiding this comment.
Can we align user config's ext?
luhc228
reviewed
Nov 26, 2024
| 'tailwind.config.cjs', | ||
| existsSync(userConfig) | ||
| ? `\ | ||
| const config = require(${JSON.stringify(userConfig)}) |
There was a problem hiding this comment.
Should we need to consider the userConfig is an ESM file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support Tailwind CSS v3.1 and Tailwind CSS v3.2.
Details
Since Tailwind CSS support using ESM configuration in V3.3, we need to use CJS configuration before that.
As mentioned in #7 (comment), we use
readFile+require.resolveto get the version oftailwindcss/package.json.satisfies(version, ^3.3.0), we will generate ESM configuration to support both ESM and CJS.Test plan
We setup two new entries in the testing matrix
As you can see, the test is failing at 0e05c6a.
And after the fix is landed in e783415, the test for old tailwindcss is passing.
Related links
close: #18