Rails/TransactionExitStatement false positive?

[modosc]

Rails/TransactionExitStatement is catching this code but i don't think it's correct:

Foo.transaction do 
  # stuff
rescue => e
  return false
end

i believe in this case return is being called outside of the transaction and therefore isn't exiting the transaction (at this point the txn already exited by raising an error).

---

Expected behavior

this code should be ignored.

Actual behavior

this code is flagged.

Steps to reproduce the problem

see above code.

RuboCop version

$ rubocop -V
1.26.0 (using Parser 3.1.1.0, rubocop-ast 1.16.0, running on ruby 3.1.1 x86_64-darwin21)
  - rubocop-performance 1.13.3
  - rubocop-rails 2.14.0
  - rubocop-rspec 2.9.0

[modosc]

thanks!

[koic]

JFYI, this behavior is not a false positive and will be changed by #696. Please see below for the reason:
#674 (comment)