Fix a false negative for Rails/TransactionExitStatement
#696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_false_negative_for_rails_transaction_exit_statement
branch
from
fc8ae80
to
f229951
Compare
10 tasks
koic
force-pushed
the
fix_false_negative_for_rails_transaction_exit_statement
branch
from
f229951
to
d5dfc68
Compare
Follow up rubocop#674 (comment) Revert "[Fix rubocop#669] Fix a false positive for `Rails/TransactionExitStatement`" This reverts commit d9ec02d and add an example, tweak a spec. So this PR fixes a false negative for `Rails/TransactionExitStatement` when `return` is used in `rescue`.
koic
force-pushed
the
fix_false_negative_for_rails_transaction_exit_statement
branch
from
d5dfc68
to
6866080
Compare
|
Should this cop also be enabled for |
koic
deleted the
fix_false_negative_for_rails_transaction_exit_statement
branch
|
This PR is not for that purpose. It can be treated as another story. Please open an issue with details if you like :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #674 (comment)
Revert "[Fix #669] Fix a false positive for
Rails/TransactionExitStatement"This reverts commit d9ec02d and tweak a spec.
So this PR fixes a false negative for
Rails/TransactionExitStatementwhenreturnis used inrescue.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.and description in grammatically correct, complete sentences.