Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove object_id from Rails/DangerousColumnNames targets #1231

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented Jan 21, 2024

Rails 7.1.3 has been released and it includes a change that object_id is no longer a dangerous column, so let's remove this from Rails/DangerousColumnNames as well.

This change was originally planned in the following comments:


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic merged commit 70288d7 into rubocop:master Jan 21, 2024
13 checks passed
@koic
Copy link
Member

koic commented Jan 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants