Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove object_id from Rails/DangerousColumnNames targets #1231

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Remove object_id from Rails/DangerousColumnNames targets #1231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/change_remove_object_id_from.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* [#1231](https://github.com/rubocop/rubocop-rails/pull/1231): Remove `object_id` from `Rails/DangerousColumnNames` targets. ([@r7kamura][])
3 changes: 1 addition & 2 deletions lib/rubocop/cop/rails/dangerous_column_names.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class DangerousColumnNames < Base # rubocop:disable Metrics/ClassLength
time
].to_set.freeze

# Generated from `ActiveRecord::AttributeMethods.dangerous_attribute_methods` on activerecord 7.1.0.
# Generated from `ActiveRecord::AttributeMethods.dangerous_attribute_methods` on activerecord 7.1.3.
# rubocop:disable Metrics/CollectionLiteralLength
DANGEROUS_COLUMN_NAMES = %w[
__callbacks
Expand Down Expand Up @@ -290,7 +290,6 @@ class DangerousColumnNames < Base # rubocop:disable Metrics/ClassLength
new_record
no_touching
normalize_reflection_attribute
object_id
partial_inserts
partial_updates
perform_validations
Expand Down