Fix an error for Rails/Validation when passing no arguments
#1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
commented
Aug 22, 2024
| @@ -1,225 +1,179 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| RSpec.describe RuboCop::Cop::Rails::Validation, :config do | |||
| it 'accepts new style validations' do | |||
There was a problem hiding this comment.
I removed this test, expect_correction would raise an InfiniteLoopError if this wouldn't pass
| expect_no_offenses('validates :name') | ||
| end | ||
|
|
||
| described_class::RESTRICT_ON_SEND.each_with_index do |validation, number| |
There was a problem hiding this comment.
I removed these tests, they are duplicated with the loop below.
Earlopain
force-pushed
the
validation-error
branch
from
1efc402
to
5e2237a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first commit, I port the specs over to using
expect_offenseand similar. It's shorter and easier to understand.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.