chore: refactor "exposed" @system_dir
instance variable (in helper method)
#604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very unclear why the
Rake::TestCase#rake_system_dir
helper method:... creates and sets a
@system_dir
instance variable. 🤔On inspection, it turns out its only use is the following assertion in one of the test cases:
... so this PR removes the ivar and hardcodes the expected
"system"
value in the assertion:This may seem a tad controversial, but as it turns out, the
sys1.rake
Rakefile name and theSYS1
Rakefile contents (also "private" - as it were - to that very same utility method) are already hardcoded in one of the Rake test cases:... so the change in this PR just makes things more consistent with the other test cases and assertions.