Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor "exposed" @system_dir instance variable (in helper method) #604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: refactor "exposed" @system_dir instance variable (in helper method) #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,17 +91,17 @@ def ignore_deprecations
end

def rake_system_dir
@system_dir = "system"
system_dir = "system"

FileUtils.mkdir_p @system_dir
FileUtils.mkdir_p system_dir

File.write File.join(@system_dir, "sys1.rake"), <<~SYS
File.write File.join(system_dir, "sys1.rake"), <<~SYS
task "sys1" do
puts "SYS1"
end
SYS

ENV["RAKE_SYSTEM"] = @system_dir
ENV["RAKE_SYSTEM"] = system_dir
end

def rakefile(contents)
Expand Down
2 changes: 1 addition & 1 deletion test/test_rake_application.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ def test_load_from_system_rakefile
load_rakefile
end

assert_equal @system_dir, @app.system_dir
assert_equal "system", @app.system_dir
assert_nil @app.rakefile
rescue SystemExit
flunk "failed to load rakefile"
Expand Down