This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Print friendly error for Thor::AmbiguousTaskError #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move the dispatch integration specs into other load friendly_errors so we can unit test it require Thor so we can rescue the errors bump ArgumentError above Exception so it wins
overrides Thor#start in Bundler::CLI to ensure Bundler.ui is set to UI::Shell.new fixes typo in friendly error message only sets UI::Sell.new in Bundler::CLI#start if exception is raised fixes typo in lib adds more specs rescues Thor::AmbiguousTaskError instead of ArgumentError removes message from spec as it's not needed
| bundle "install" | ||
| expect(err).to eq("") | ||
| expect(out).to match(/Bundler::GemfileNotFound/) | ||
| end |
There was a problem hiding this comment.
I'm not sure this is a good spec or not. The command is being dispatched correctly, but is not actually successful. Should the Gemfile be setup? Same for the next one.
There was a problem hiding this comment.
I would probably just add expect(out).to_not match(/ambiguous command/i) or whatever is appropriate.
|
👍 |
indirect
added a commit
that referenced
this pull request
Aug 6, 2013
…s-task Print friendly error for Thor::AmbiguousTaskError
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2550