Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Print friendly error for Thor::AmbiguousTaskError #2581

Merged
merged 5 commits into from
Aug 6, 2013
Merged

Print friendly error for Thor::AmbiguousTaskError #2581

merged 5 commits into from
Aug 6, 2013

Commits on Aug 5, 2013

  1. rescues ArgumentError with message that matches 'Ambiguous task'

    @jendiamond @jlsuttles
    jendiamond authored and jlsuttles committed Aug 5, 2013
    Configuration menu
    Copy the full SHA
    22f7f9f View commit details
    Browse the repository at this point in the history

  2. tries to test friendly errors, but fails

    @jhhere @jlsuttles
    jhhere authored and jlsuttles committed Aug 5, 2013
    Configuration menu
    Copy the full SHA
    4a53681 View commit details
    Browse the repository at this point in the history

  3. break out cli command specs into a dedicated dir 

    move the dispatch integration specs into other

load friendly_errors so we can unit test it

require Thor so we can rescue the errors

bump ArgumentError above Exception so it wins
    @indirect @jlsuttles
    indirect authored and jlsuttles committed Aug 5, 2013
    Configuration menu
    Copy the full SHA
    0750d45 View commit details
    Browse the repository at this point in the history

  4. trying to get specs to pass 

    overrides Thor#start in Bundler::CLI to ensure Bundler.ui is set to UI::Shell.new

fixes typo in friendly error message

only sets UI::Sell.new in Bundler::CLI#start if exception is raised

fixes typo in lib

adds more specs

rescues Thor::AmbiguousTaskError instead of ArgumentError

removes message from spec as it's not needed
    @jlsuttles
    jlsuttles committed Aug 5, 2013
    Configuration menu
    Copy the full SHA
    8d385e0 View commit details
    Browse the repository at this point in the history

  5. updates bundle command names spec

    @jlsuttles
    jlsuttles committed Aug 5, 2013
    Configuration menu
    Copy the full SHA
    f8211e9 View commit details
    Browse the repository at this point in the history