Add support for cargo --explain
#2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @brson |
|
May want to not merge this until rust-lang/rust#32756 is approved, but may also be good regardless either way. |
|
Should all subcommands that can pass-through errors support this too? E.g. |
|
Hm perhaps? We need to be careful about hijacking top-level arguments, however, as cargo subcommands may be using them in various ways. |
|
I think I prefer leaving it just |
|
☔ The latest upstream changes (presumably #2590) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r+ |
|
📌 Commit f73d55a has been approved by |
|
🔒 Merge conflict |
The error messages in the compiler are being tweaked and will likely drop the `rustc --explain` part of the error message in favor of `--explain`. In that case you're expected to basically take whatever tool you're using and pass `--explain` to it with an error code, so let's add it to Cargo as well!
bors
added a commit
that referenced
this pull request
Apr 21, 2016
Add support for `cargo --explain` The error messages in the compiler are being tweaked and will likely drop the `rustc --explain` part of the error message in favor of `--explain`. In that case you're expected to basically take whatever tool you're using and pass `--explain` to it with an error code, so let's add it to Cargo as well!
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
epage
added a commit
to epage/cargo
that referenced
this pull request
Aug 29, 2023
In working on rust-lang#12578, I'm focusing on each help string to decide how it should be handled and I noticed this. It feels weird to explain something in terms of another command's CLI, so I took `rustc --help`s message and added `rustc` to clarify it. Looking back, the flag was added in rust-lang#2551 with the message we have today. Nothing seems to really be said about it. In reflecting on this, I'm not 100% convinced and am open to other opinions.
bors
added a commit
that referenced
this pull request
Aug 29, 2023
fix(help): Explain --explain In working on #12578, I'm focusing on each help string to decide how it should be handled and I noticed this. It feels weird to explain something in terms of another command's CLI, so I took `rustc --help`s message and added `rustc` to clarify it. Looking back, the flag was added in #2551 with the message we have today. Nothing seems to really be said about it. In reflecting on this, I'm not 100% convinced and am open to other opinions.
epage
added a commit
to epage/cargo
that referenced
this pull request
Aug 30, 2023
In working on rust-lang#12578, I'm focusing on each help string to decide how it should be handled and I noticed this. It feels weird to explain something in terms of another command's CLI, so I took `rustc --help`s message and added `rustc` to clarify it. Looking back, the flag was added in rust-lang#2551 with the message we have today. Nothing seems to really be said about it. In reflecting on this, I'm not 100% convinced and am open to other opinions.
bors
added a commit
that referenced
this pull request
Aug 30, 2023
fix(help): Explain --explain In working on #12578, I'm focusing on each help string to decide how it should be handled and I noticed this. It feels weird to explain something in terms of another command's CLI, so I took `rustc --help`s message and added `rustc` to clarify it. Looking back, the flag was added in #2551 with the message we have today. Nothing seems to really be said about it. In reflecting on this, I'm not 100% convinced and am open to other opinions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error messages in the compiler are being tweaked and will likely drop the
rustc --explainpart of the error message in favor of--explain. In thatcase you're expected to basically take whatever tool you're using and pass
--explainto it with an error code, so let's add it to Cargo as well!