Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have CLI take preference over config for verbosity #2590

Merged

Conversation

alexcrichton
Copy link
Member

If a CLI option is passed, that trumps any command line configuration, otherwise
just do what we did previously.

Closes #2588

If a CLI option is passed, that trumps any command line configuration, otherwise
just do what we did previously.

Closes rust-lang#2588
@rust-highfive
Copy link

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned huonw Apr 18, 2016
@brson
Copy link
Contributor

brson commented Apr 19, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Apr 19, 2016

📌 Commit b40e1db has been approved by brson

@bors
Copy link
Contributor

bors commented Apr 19, 2016

⌛ Testing commit b40e1db with merge 8975f30...

bors added a commit that referenced this pull request Apr 19, 2016
… r=brson

Have CLI take preference over config for verbosity

If a CLI option is passed, that trumps any command line configuration, otherwise
just do what we did previously.

Closes #2588
@bors
Copy link
Contributor

bors commented Apr 19, 2016

@bors bors merged commit b40e1db into rust-lang:master Apr 19, 2016
@alexcrichton alexcrichton deleted the dont-warn-about-flags-and-configs branch April 21, 2016 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants