Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to I-nominated in CONTRIBUTING.md #5325

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Fix link to I-nominated in CONTRIBUTING.md #5325

merged 1 commit into from
Apr 9, 2018

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Apr 9, 2018

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@matklad
Copy link
Member

matklad commented Apr 9, 2018

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Apr 9, 2018

📌 Commit 463f207 has been approved by matklad

@bors
Copy link
Contributor

bors commented Apr 9, 2018

⌛ Testing commit 463f207 with merge d8b2031...

bors added a commit that referenced this pull request Apr 9, 2018
Fix link to I-nominated in CONTRIBUTING.md
@bors
Copy link
Contributor

bors commented Apr 9, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing d8b2031 to master...

@bors bors merged commit 463f207 into rust-lang:master Apr 9, 2018
@dwijnand dwijnand deleted the patch-1 branch April 9, 2018 20:09
@dwijnand
Copy link
Member Author

btw I noticed highfive linked me to the rust CONTRIBUTING.md rather than cargo's, so I proposed to change that over at rust-lang/highfive#132.

@ehuss ehuss added this to the 1.27.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants