Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

link cargo to its CONTRIBUTING.md #132

Merged
merged 1 commit into from
Apr 12, 2018
Merged

link cargo to its CONTRIBUTING.md #132

merged 1 commit into from
Apr 12, 2018

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Apr 10, 2018

note this is just from a quick look at the code and the README - I'm not sure if this is right, so feedback very welcome.

@nrc
Copy link
Member

nrc commented Apr 12, 2018

Heh, I have literally no idea whether this will work! This is a feature from Servo highfive that we don't use. However, it looks like it should work, so let's give it a go!

@nrc nrc merged commit 9bbb840 into rust-lang:master Apr 12, 2018
@dwijnand dwijnand deleted the cargo-contributing branch April 12, 2018 10:19
@dwijnand
Copy link
Member Author

assuming this change is what is running, it looks like it didn't work :(

rust-lang/cargo#5367 (comment)

@davidalber
Copy link
Collaborator

I suspect your change has not been deployed. This is what happens on master:

>>> from highfive import newpr
>>> config = """{
...     "groups": {
...         "all": ["@alexcrichton", "@matklad"]
...     },
...     "dirs": {
...         "doc": ["doc"]
...     },
...     "contributing": "https://github.com/rust-lang/cargo/blob/master/CONTRIBUTING.md"
... }"""
>>> import json
>>> newpr.welcome_msg('foouser', json.loads(config))
u"Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @foouser (or someone else) soon.\n\nIf any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.\n\nPlease see [the contribution instructions](https://github.com/rust-lang/cargo/blob/master/CONTRIBUTING.md) for more information.\n"

@nrc
Copy link
Member

nrc commented Apr 17, 2018

I deployed just now (I tend to batch changes and deploy once per week or so), so the next PR to Cargo should see this change

@dwijnand
Copy link
Member Author

confirmed! 🎉 rust-lang/cargo#5402 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants