-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop MIPS to tier 3 #648
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed. cc @rust-lang/compiler @rust-lang/compiler-contributors |
@rustbot second |
It's important it explicitly add that if someone steps up, fixes these issues and volunteers to be a target maintainer, we can promote them again. |
Remove `mips*-unknown-linux-gnu*` builders Pursuant to the current consensus in rust-lang/compiler-team#648
While I left it ambiguous at first, I should note the conversation on Zulip inclined towards applying the same judgement to all of the "preexisting" tier 2 MIPS targets, one way or another. Also, while not necessarily immediately affecting this decision, we should probably insist that targets have support from active maintainers for their codegen backend as well, especially before promoting them to higher tiers, lest we have other cases like this. This apparently is currently not true for MIPS and its LLVM backend. |
These targets have been removed from rustup, see rust-lang/compiler-team#648.
This MCP is accepted 🎉 |
These targets have been removed from rustup, see rust-lang/compiler-team#648.
Currently, Tokio runs cross-compilation checks for the `mips-unknown-linux-gnu` and `mipsel-unknown-linux-musl` target triples. However, Rust has recently demoted these targets from Tier 2 support to Tier 3 (see rust-lang/compiler-team#648). Therefore, MIPS toolchains may not always be available, even in stable releases. This is currently [breaking our CI builds][1], as Rust 1.72.0 does not contain a standard library for `mips-unknown-linux-gnu`. This branch removes these builds from the cross-compilation check's build matrix. Tokio may still build successfully for MIPS targets, but we can't easily guarantee support when the stable Rust release train may or may not be able to build for MIPS targets. [1]: https://github.com/tokio-rs/tokio/actions/runs/5970263562/job/16197657405?pr=5947#step:3:80
`mips-unknown-linux-gnu` and `mips64-unknown-linux-gnuabi64` have been dropped to Tier 3 since rust 1.72 by rust-lang/compiler-team#648. Hence, they are no longer available even in the nightly channel. Signed-off-by: Manabu Sugimoto <[email protected]>
`mips-unknown-linux-gnu` and `mips64-unknown-linux-gnuabi64` have been dropped to Tier 3 since rust 1.72 by rust-lang/compiler-team#648. Hence, they are no longer available even in the nightly channel. Signed-off-by: Manabu Sugimoto <[email protected]>
`mips-unknown-linux-gnu` and `mips64-unknown-linux-gnuabi64` have been dropped to Tier 3 since rust 1.72 by rust-lang/compiler-team#648. Hence, they are no longer available even in the nightly channel. Signed-off-by: Manabu Sugimoto <[email protected]>
`mips-unknown-linux-gnu` and `mips64-unknown-linux-gnuabi64` have been dropped to Tier 3 since rust 1.72 by rust-lang/compiler-team#648. Hence, they are no longer available even in the nightly channel. Signed-off-by: Manabu Sugimoto <[email protected]>
`mips-unknown-linux-gnu` and `mips64-unknown-linux-gnuabi64` have been dropped to Tier 3 since rust 1.72 by rust-lang/compiler-team#648. Hence, they are no longer available even in the nightly channel. Signed-off-by: Manabu Sugimoto <[email protected]>
- rust-lang/compiler-team#648 - mips-* targets are now dropped to tier 3 - ref #1426
`mips-unknown-linux-gnu` and `mips64-unknown-linux-gnuabi64` have been dropped to Tier 3 since rust 1.72 by rust-lang/compiler-team#648. Hence, they are no longer available even in the nightly channel. Signed-off-by: Manabu Sugimoto <[email protected]>
- mips-* targets are moved to Tier-3 rust-lang/compiler-team#648 - cargo nightly provides -Zbuild-std to build libstd while compiling - cross supports build-std
Proposal
The target tier policy exists to guarantee targets have a minimum of support and don't cause problems in our CI. The existing tier 2 MIPS targets are causing problems in our CI. Specifically, cross builds from x86-64 hosts to build toolchains suitable for deployment on these hosts:
Judging by issue rust-lang/rust#113065 this appears to be caused by problems that emerge during isel in LLVM. No one has emerged with an emergency patch to our LLVM fork which resolves the build for these targets. We have opened llvm/llvm-project#63608 upstream but it has yet to receive an acknowledgement that anyone is working on it. Certainly I do not expect anyone to suddenly wave their magic wand and simply banish these problems, but with no efforts to improve maintenance for them coming forward except for the mips{32,64}r6 targets, which are actually different ISAs due to backwards incompatibility, it is apparent this is a clear violation of both the spirit1234 and letter567 of the target tier policy. I recommend we immediately drop all of these problematic targets to tier 3 per the target tier policy89.
I have left ambiguous the fate of the following tier 2 targets without host tools. I have not observed them causing a problem yet, but it is apparent to me they are not actually receiving tier 2 maintenance, either. The lack of problems may be more of a feature of the GNU targets causing problems first, or it may be a feature of them exercising less of the compiler due to only building the stdlib's binary artifacts and whatever support necessary.
Mentors or Reviewers
Process
The main points of the Major Change Process are as follows:
@rustbot second
.-C flag
, then full team check-off is required.@rfcbot fcp merge
on either the MCP or the PR.You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
Footnotes
The text was updated successfully, but these errors were encountered: