Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mips*-unknown-linux-gnu* builders #113274

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Remove mips*-unknown-linux-gnu* builders #113274

merged 1 commit into from
Jul 4, 2023

Conversation

workingjubilee
Copy link
Member

@workingjubilee workingjubilee commented Jul 3, 2023 •
edited
Loading

Pursuant to the current consensus in rust-lang/compiler-team#648

@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 3, 2023
@workingjubilee
Copy link
Member Author

...of course I forget to r? @ghost

@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2023

Failed to set assignee to ghost: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@tgross35
Copy link
Contributor

tgross35 commented Jul 3, 2023

(asking for my own curiosity, not really suggesting anything) is there a need to remove all the dist-mips folders? It seems likely enough that they may be reenabled at some point, so maybe worth keeping them in tree with history and all? Or moved to a different directory if some tool automatically looks for the dist-x dirs

@Noratrieb
Copy link
Member

git preserves all history, if one needs to be a git historian.

@workingjubilee
Copy link
Member Author

workingjubilee commented Jul 3, 2023 •
edited
Loading

Given that commits can also be easily reverted, I have received a recommendation that we should in fact remove these builders immediately, rather than waiting, as the burden has made it so essentially every PR merged lately has had one bors retry (...averaged). Which is fine by me, assuming that I did this correctly and everyone's on board. I will remove the "formally change the platform support page" commit to another PR.

@workingjubilee workingjubilee changed the title Demote mips*-unknown-linux-gnu* to tier 3 Remove mips*-unknown-linux-gnu* builders Jul 3, 2023
@workingjubilee workingjubilee marked this pull request as ready for review July 3, 2023 07:37
@klensy
Copy link
Contributor

klensy commented Jul 3, 2023

But there some folder with promising name https://github.com/rust-lang/rust/tree/master/src/ci/docker/host-x86_64/disabled

@nikic
Copy link
Contributor

nikic commented Jul 3, 2023

I don't think this should touch anything more than the CI configuration.

@workingjubilee
Copy link
Member Author

So just 634f952 ?

@jyn514
Copy link
Member

jyn514 commented Jul 4, 2023

https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/Drop.20MIPS.20to.20tier.203.20compiler-team.23648/near/372165737:

I think an easy workaround is to land now, and revert on (future) beta. We can get past the bugs with a couple retries on the beta + stable compiler builds, but this fixes most folks builds now.

@bors r+ p=50 rollup=never

@bors
Copy link
Contributor

bors commented Jul 4, 2023

📌 Commit 634f952 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2023
@jyn514 jyn514 mentioned this pull request Jul 4, 2023
Merged
@bors
Copy link
Contributor

bors commented Jul 4, 2023

⌛ Testing commit 634f952 with merge 2c2f5cf020a890a48e8b4ff87ccad8cfdf118be1...

@compiler-errors
Copy link
Member

@bors ping

@bors
Copy link
Contributor

bors commented Jul 4, 2023

😪 I'm awake I'm awake

@compiler-errors
Copy link
Member

@bors treeclosed=100 the tree is fucked up because of a raced try-build and auto merge in #113213

@compiler-errors
Copy link
Member

gonna bump this auto build out of the queue, hope that's the right step here to make sure things don't get worse :(

@bors retry

@compiler-errors
Copy link
Member

(haha, bors probably wouldn't have even merged 634f952 because it's not a fast forward.)

@compiler-errors
Copy link
Member

@bors p=50
@bors retry

^^

@workingjubilee
Copy link
Member Author

@bors r- p=50

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 4, 2023
@compiler-errors
Copy link
Member

I think this can resume build now, thanks @Mark-Simulacrum for fixing the tree.

@bors r=jyn514
@bors treeclosed-

@bors
Copy link
Contributor

bors commented Jul 4, 2023

📌 Commit 634f952 has been approved by jyn514

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 4, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 4, 2023
@bors
Copy link
Contributor

bors commented Jul 4, 2023

⌛ Testing commit 634f952 with merge 9e4e584...

@compiler-errors
Copy link
Member

The merge looks correct

@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
curl: (22) The requested URL returned error: 404 

error: failed to download llvm from ci

    help: old builds get deleted after a certain time
    help: if trying to compile an old commit of rustc, disable `download-ci-llvm` in config.toml:
    [llvm]
    download-ci-llvm = false
    
Build completed unsuccessfully in 0:00:00

@compiler-errors
Copy link
Member

Or not?

@compiler-errors
Copy link
Member

Actually, that looks like a previous auto-merge, not this one.

#113274 (comment)

@workingjubilee
Copy link
Member Author

should this retry then?

@compiler-errors
Copy link
Member

No need -- it's merging successfully in https://github.com/rust-lang-ci/rust/actions/runs/5457834781

@workingjubilee
Copy link
Member Author

Weird.

@bors
Copy link
Contributor

bors commented Jul 4, 2023

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 9e4e584 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 4, 2023
@bors bors merged commit 9e4e584 into rust-lang:master Jul 4, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jul 4, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9e4e584): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.0% [-3.0%, -3.0%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 653.659s -> 653.846s (0.03%)

@workingjubilee workingjubilee deleted the demote-mips branch July 5, 2023 00:51
@workingjubilee workingjubilee mentioned this pull request Jul 16, 2023
Open
57 tasks
@zachs18 zachs18 mentioned this pull request Jul 17, 2023
Merged
@CryZe CryZe mentioned this pull request Aug 24, 2023
Open
@ehuss ehuss mentioned this pull request Oct 7, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 10, 2023
@matthiaskrgr
Rollup merge of rust-lang#116503 - ehuss:fix-mips-tier, r=Amanieu
84e1e14 
Update docs for mips target tier demotion.

These mips targets were demoted in rust-lang#113274, but the documentation was not updated. I have also elected to document this in the release notes for 1.72 because I think that should have been included.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 10, 2023
@GuillaumeGomez
Rollup merge of rust-lang#116503 - ehuss:fix-mips-tier, r=Amanieu
fccf9ec 
Update docs for mips target tier demotion.

These mips targets were demoted in rust-lang#113274, but the documentation was not updated. I have also elected to document this in the release notes for 1.72 because I think that should have been included.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2023
@rust-timer
Unrolled build for rust-lang#116503
5ce385a 
Rollup merge of rust-lang#116503 - ehuss:fix-mips-tier, r=Amanieu

Update docs for mips target tier demotion.

These mips targets were demoted in rust-lang#113274, but the documentation was not updated. I have also elected to document this in the release notes for 1.72 because I think that should have been included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.