Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove several alumni from experts/map.toml #691

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

workingjubilee
Copy link
Member

This file is an attractive nuisance that inspires people to bother contributors who have decided their time with the project is done. Perhaps it should be simply deleted wholesale. That seems like a somewhat radical position, so I merely culled several names that haven't contributed to the compiler recently, or that I recognize as having actively decided to distance themselves. Or, in one case, an officially-over project.

@nnethercote
Copy link

There is another TOML file somewhere (I don't remember where) that defines who can review certain parts of the compiler. That seems like the more definitive guide for this kind of information, and less likely to get out of date given that it affects the review distribution.

@jackh726
Copy link
Member

I agree that this is probably not a good place for this type of information, but given that it's here, any improvement is worth it.

Am going to go ahead and merge this, but we should consider removing it outright.

@jackh726 jackh726 merged commit 07ea32c into rust-lang:master Nov 19, 2023
@workingjubilee workingjubilee deleted the patch-1 branch November 20, 2023 05:17
@spastorino
Copy link
Member

Have commented about this in a similar PR that was done to the dev guide. I think we should remove this file probably cc @davidtwco @wesleywiser

@jyn514
Copy link
Member

jyn514 commented Dec 2, 2023

There is another TOML file somewhere (I don't remember where) that defines who can review certain parts of the compiler. That seems like the more definitive guide for this kind of information, and less likely to get out of date given that it affects the review distribution.

https://github.com/rust-lang/rust/blob/7be0546bd121c06b37cce9139af8b7c7e012cb25/triagebot.toml#L627-L804

@davidtwco
Copy link
Member

Have commented about this in a similar PR that was done to the dev guide. I think we should remove this file probably cc @davidtwco @wesleywiser

I lean in this direction too - experts map has never been something we've been good at keeping up-to-date, so we should probably look at other approaches at solving this problem.

@spastorino
Copy link
Member

Done in #698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants