Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emphasize that the experts map is not up to date #1826

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Emphasize that the experts map is not up to date #1826

merged 1 commit into from
Nov 22, 2023

Conversation

nouritsu
Copy link
Contributor

From Zulip Conversation
Adds greater emphasis on the fact that the expert's map is outdated.
Also cleans up accidental double spaces and formats document.

@ChrisDenton
Copy link
Member

Hmm... should we simply remove the map? It seems less than useful if it isn't kept up to date.

@nouritsu
Copy link
Contributor Author

I vote for yes, for the following reasons -

  • the map's sole purpose is to connect contributors to experts, its redundant if the list of experts is not up to date
  • the community helps one another out even if they are not an expert in a certain topic, both on zulip and on discord
  • experts already offer to mentor contributors in the github issues section for rust

@workingjubilee
Copy link
Member

Yeah, we can simply delete the refs to the experts map.

@nouritsu
Copy link
Contributor Author

I'll push to my repository so this pr is updated

@tshepang
Copy link
Member

instead of hiding that it exists, we should instead delete it first, and only then remove the reference

@nouritsu
Copy link
Contributor Author

I second that.

@tshepang tshepang merged commit 4d43a3b into rust-lang:master Nov 22, 2023
1 check passed
@spastorino
Copy link
Member

I think we should probably delete the expert file and this reference altogether but I'd rather have @davidtwco or @wesleywiser weighing in here.

The idea of documenting somewhere or having a way to see who could we consult on certain areas of the compiler is a good one but pretty hard to maintain and keep up to date.
David, Wesley, any thought about this?.

@davidtwco
Copy link
Member

I think we should probably delete the expert file and this reference altogether but I'd rather have @davidtwco or @wesleywiser weighing in here.

The idea of documenting somewhere or having a way to see who could we consult on certain areas of the compiler is a good one but pretty hard to maintain and keep up to date. David, Wesley, any thought about this?.

I think we should delete the map for now - we should solve this problem, like Santiago says, it's a worthwhile thing to have a solution for - but the out-of-date map is more confusing than helpful.

@rustbot rustbot mentioned this pull request Dec 4, 2023
Merged
@spastorino
Copy link
Member

spastorino commented Dec 4, 2023 •
edited
Loading

Opened a PR to remove the experts map rust-lang/compiler-team#698.
If we land that we should update the dev guide again to remove occurrences of it too.
I liked @jyn514 idea rust-lang/compiler-team#691 (comment), maybe we could mention that from the guide.

fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Dec 5, 2023
@fee1-dead
Rollup merge of rust-lang#118614 - rustbot:docs-update, r=ehuss
834a8e8 
Update books

## rust-lang/nomicon

1 commits in 1842257814919fa62e81bdecd5e8f95be2839dbb..83d015105e6d490fc30d6c95da1e56152a50e228
2023-11-22 15:35:31 UTC to 2023-11-22 15:35:31 UTC

- Reword the section on general race conditions (rust-lang/nomicon#431)

## rust-lang/reference

5 commits in cd8193e972f61b92117095fc73b67af767b4d6bc..692d216f5a1151e8852ddb308ba64040e634c876
2023-12-04 09:45:06 UTC to 2023-11-21 17:57:18 UTC

- Fix note on `self` coercion (rust-lang/reference#1431)
- Document C string literal tokens. (rust-lang/reference#1423)
- type-layout.md: Warn about repr(align)/repr(packed) and field order (rust-lang/reference#1430)
- Lone `self` in a method body resolves to the self parameter (rust-lang/reference#1427)
- Reference wildcard patterns from underscore expr (rust-lang/reference#1428)

## rust-lang/rust-by-example

4 commits in a6581246f96837113968c02187db24f742af3908..da0a06aada31a324ae84a9eaee344f6a944b9683
2023-11-27 12:50:49 UTC to 2023-11-21 11:58:19 UTC

- fix tiny typo in string conversion docs (rust-lang/rust-by-example#1776)
- fix(arg): Remove reference to Rust Cookbook in arg parsing (rust-lang/rust-by-example#1775)
- fix:typo error (rust-lang/rust-by-example#1774)
- Remove space between `&` and `self` (rust-lang/rust-by-example#1772)

## rust-lang/rustc-dev-guide

5 commits in ddb8b13..904bb5a
2023-11-28 13:13:36 UTC to 2023-11-22 06:13:00 UTC

- Update how-to-build-and-run.md (rust-lang/rustc-dev-guide#1828)
- notification groups: add information about how to ping them (rust-lang/rustc-dev-guide#1818)
- Add explanations on how to run rustc_codegen_gcc tests (rust-lang/rustc-dev-guide#1821)
- Add back the `canonicalization` chapter. (rust-lang/rustc-dev-guide#1532)
- Emphasize that the experts map is not up to date (rust-lang/rustc-dev-guide#1826)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 5, 2023
@matthiaskrgr
Rollup merge of rust-lang#118614 - rustbot:docs-update, r=ehuss
4b40b1b 
Update books

## rust-lang/nomicon

1 commits in 1842257814919fa62e81bdecd5e8f95be2839dbb..83d015105e6d490fc30d6c95da1e56152a50e228
2023-11-22 15:35:31 UTC to 2023-11-22 15:35:31 UTC

- Reword the section on general race conditions (rust-lang/nomicon#431)

## rust-lang/reference

5 commits in cd8193e972f61b92117095fc73b67af767b4d6bc..692d216f5a1151e8852ddb308ba64040e634c876
2023-12-04 09:45:06 UTC to 2023-11-21 17:57:18 UTC

- Fix note on `self` coercion (rust-lang/reference#1431)
- Document C string literal tokens. (rust-lang/reference#1423)
- type-layout.md: Warn about repr(align)/repr(packed) and field order (rust-lang/reference#1430)
- Lone `self` in a method body resolves to the self parameter (rust-lang/reference#1427)
- Reference wildcard patterns from underscore expr (rust-lang/reference#1428)

## rust-lang/rust-by-example

4 commits in a6581246f96837113968c02187db24f742af3908..da0a06aada31a324ae84a9eaee344f6a944b9683
2023-11-27 12:50:49 UTC to 2023-11-21 11:58:19 UTC

- fix tiny typo in string conversion docs (rust-lang/rust-by-example#1776)
- fix(arg): Remove reference to Rust Cookbook in arg parsing (rust-lang/rust-by-example#1775)
- fix:typo error (rust-lang/rust-by-example#1774)
- Remove space between `&` and `self` (rust-lang/rust-by-example#1772)

## rust-lang/rustc-dev-guide

5 commits in ddb8b13..904bb5a
2023-11-28 13:13:36 UTC to 2023-11-22 06:13:00 UTC

- Update how-to-build-and-run.md (rust-lang/rustc-dev-guide#1828)
- notification groups: add information about how to ping them (rust-lang/rustc-dev-guide#1818)
- Add explanations on how to run rustc_codegen_gcc tests (rust-lang/rustc-dev-guide#1821)
- Add back the `canonicalization` chapter. (rust-lang/rustc-dev-guide#1532)
- Emphasize that the experts map is not up to date (rust-lang/rustc-dev-guide#1826)
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 5, 2023
@rust-timer
Unrolled build for rust-lang#118614
c3e3a50 
Rollup merge of rust-lang#118614 - rustbot:docs-update, r=ehuss

Update books

## rust-lang/nomicon

1 commits in 1842257814919fa62e81bdecd5e8f95be2839dbb..83d015105e6d490fc30d6c95da1e56152a50e228
2023-11-22 15:35:31 UTC to 2023-11-22 15:35:31 UTC

- Reword the section on general race conditions (rust-lang/nomicon#431)

## rust-lang/reference

5 commits in cd8193e972f61b92117095fc73b67af767b4d6bc..692d216f5a1151e8852ddb308ba64040e634c876
2023-12-04 09:45:06 UTC to 2023-11-21 17:57:18 UTC

- Fix note on `self` coercion (rust-lang/reference#1431)
- Document C string literal tokens. (rust-lang/reference#1423)
- type-layout.md: Warn about repr(align)/repr(packed) and field order (rust-lang/reference#1430)
- Lone `self` in a method body resolves to the self parameter (rust-lang/reference#1427)
- Reference wildcard patterns from underscore expr (rust-lang/reference#1428)

## rust-lang/rust-by-example

4 commits in a6581246f96837113968c02187db24f742af3908..da0a06aada31a324ae84a9eaee344f6a944b9683
2023-11-27 12:50:49 UTC to 2023-11-21 11:58:19 UTC

- fix tiny typo in string conversion docs (rust-lang/rust-by-example#1776)
- fix(arg): Remove reference to Rust Cookbook in arg parsing (rust-lang/rust-by-example#1775)
- fix:typo error (rust-lang/rust-by-example#1774)
- Remove space between `&` and `self` (rust-lang/rust-by-example#1772)

## rust-lang/rustc-dev-guide

5 commits in ddb8b13..904bb5a
2023-11-28 13:13:36 UTC to 2023-11-22 06:13:00 UTC

- Update how-to-build-and-run.md (rust-lang/rustc-dev-guide#1828)
- notification groups: add information about how to ping them (rust-lang/rustc-dev-guide#1818)
- Add explanations on how to run rustc_codegen_gcc tests (rust-lang/rustc-dev-guide#1821)
- Add back the `canonicalization` chapter. (rust-lang/rustc-dev-guide#1532)
- Emphasize that the experts map is not up to date (rust-lang/rustc-dev-guide#1826)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshepang tshepang tshepang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nouritsu @ChrisDenton @workingjubilee @tshepang @spastorino @davidtwco