Enable FastBoot (again) #1832
Enable FastBoot (again) #1832
Conversation
|
r? @sgrif (rust_highfive has picked a reviewer for you, use r? to override) |
Fix ESLint issues During #1832, I've realized that the indentation on `app/mixins/rl-dropdown-component.js` is off.
kzys
force-pushed
the
enable-fastboot-2
branch
3 times, most recently
from
ad72033 to
c6df1b2
Compare
|
At most ~299MB
|
|
Okay. The last commit (ebff9fe) changed the memory consumption a lot.
|
|
☔ The latest upstream changes (presumably #1837) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I will update the branch once #1853 got merged, since this branch probably will conflict with that. |
* npm i --save-dev ember-cli-fastboot * npm i --save fastboot-app-server
This class is added dynamically, after FastBoot rendering.
On Acceptance Tests, the application is rendered under #ember-testing, not the root <body> element.
As like ember-page-title, we cannot use document.title. https://github.com/adopted-ember-addons/ember-page-title/blob/4732cdb2c9f673e4714334b33c5b4c5056dfcb8f/tests/acceptance/posts-test.js#L11
kzys
force-pushed
the
enable-fastboot-2
branch
from
c9b0204 to
3e89367
Compare
|
I think it would be beneficial to break out enabling FastBoot (in the Procfile, nginx configuration, and app-initialized file handling) into a separate PR. That way we could land the other fixes in this PR ASAP, and then have a smaller PR that is easier to enable and revert if necessary. It would be ideal if we could dynamically enable/disable FastBoot via an environment variable, similar to how hyper can be selected at boot time with the USE_HYPER environment variable. However, that seems tricky in this case, because we would need to dynamically configure nginx before starting it. So I don't think we need to try to make this a dynamic configuation at this time, but I think it would make sense to break out the diff that actually enables FastBoot into its own PR and land the rest of these changes now. |
|
I think it is possible to implement the dynamic configuration, since the Nginx Buildpack is using ERB for templating. Anyway, I've created #1886 which contains Fastboot-related changes, except for actually enabling Fastboot. Please take a look! |
|
☔ The latest upstream changes (presumably #1879) made this pull request unmergeable. Please resolve the merge conflicts. |
Preparation for Fastboot (1/3) This PR contains Fastboot-related fixes (from #1832) except for actually enabling Fastboot. After merging this change, I'm going to submit a PR that updates package.json to include Fastboot in the dependencies. Then I will submit a PR that enables Fastboot, based on USE_FASTBOOT env variable.
|
Since we already have #1811 for tracking. I'm going to close this PR. We may have discussions on the tracking issue. |
Compared to #1715, this branch
clustercreates configurable, and the default value is one.The memory consumption is at most ~197MB on my Heroku environment. Of course the environment is having only a few requests from my browser though. Would it be acceptable?