Preparation for Fastboot (1/3) #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @smarnach (rust_highfive has picked a reviewer for you, use r? to override) |
kzys
force-pushed
the
fastboot-prepare
branch
from
a6fa0fd to
47e4077
Compare
|
Hm, when I try to run this locally with I get the same error when I run with Am I supposed to be using a different command to run locally? Do we need to set a Good news is that |
|
☔ The latest upstream changes (presumably #1879) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Oh, I was assuming just adding dependencies won't change the behavior and didn't check these npm commands. My bad... In that case, let me first revert package.json changes. That at least merging this PR easier. |
kzys
force-pushed
the
fastboot-prepare
branch
from
47e4077 to
d092fd9
Compare
- Don't use .ember-application which is added after FastBoot This class is added dynamically, after FastBoot rendering. - On Acceptance Tests, the application is rendered under #ember-testing, not the root <body> element.
As like ember-page-title, we cannot use document.title. https://github.com/adopted-ember-addons/ember-page-title/blob/4732cdb2c9f673e4714334b33c5b4c5056dfcb8f/tests/acceptance/posts-test.js#L11
kzys
force-pushed
the
fastboot-prepare
branch
from
d092fd9 to
034fd45
Compare
|
This works now, thank you!!! @bors r+ |
|
📌 Commit 034fd45 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 11, 2019
Preparation for Fastboot (1/3) This PR contains Fastboot-related fixes (from #1832) except for actually enabling Fastboot. After merging this change, I'm going to submit a PR that updates package.json to include Fastboot in the dependencies. Then I will submit a PR that enables Fastboot, based on USE_FASTBOOT env variable.
|
☀️ Test successful - checks-travis |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains Fastboot-related fixes (from #1832) except for actually enabling Fastboot.
After merging this change, I'm going to submit a PR that updates package.json to include Fastboot in the dependencies.
Then I will submit a PR that enables Fastboot, based on USE_FASTBOOT env variable.