-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding function for getting access to map table: RawTable<(K, V), A>
field
#335
Conversation
I understood. It's not my fault. It is rust-lang/rust#96150. Open pull request |
Could you expose these using functions instead? The hash builder is already exposed via the |
map-inner
feature for getting access to map fieldstable: RawTable<(K, V), A>
field
Ready. Fixed as requested. |
table: RawTable<(K, V), A>
fieldtable: RawTable<(K, V), A>
field
table: RawTable<(K, V), A>
fieldtable: RawTable<(K, V), A>
field
@bors r+ |
📌 Commit c773eb2 has been approved by |
☀️ Test successful - checks-actions |
Just like rust-lang#335 did for `HashMap`, I'd like to add access to the underlying `RawTable` for `HashSet`. I intend to use it in conjunction with rust-lang#354 to pull random elements from a `HashSet`.
Just like rust-lang#335 did for `HashMap`, I'd like to add access to the underlying `RawTable` for `HashSet`. I intend to use it in conjunction with rust-lang#354 to pull random elements from a `HashSet`.
Just like rust-lang#335 did for `HashMap`, I'd like to add access to the underlying `RawTable` for `HashSet`. I intend to use it in conjunction with rust-lang#354 to pull random elements from a `HashSet`.
Add HashSet#raw_table Just like #335 did for `HashMap`, I'd like to add access to the underlying `RawTable` for `HashSet`. I intend to use it in conjunction with #354 to pull random elements from a `HashSet`. Let me know if I've missed something here or you'd like things implemented differently. I'll be happy to change it up!
I was a little interested in issues "API for removing by key hash and value" #330. The original question was about adding a fancy API, and of course it wasn't merged (#334).
However, it seems to me that this shows that it would be nice to just add the ability to access to map's fields. And let the user himself do what he pleases.
The user will still not be able to change the existing API. But at the same time, he will have the opportunity to add small extensions. Otherwise, when using
RawTable
, he will have to not only add one or two functions, but generally recreate all theHashMap
’s APIs, which can be difficult.