-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uses of set_var
#2783
Comments
#3006 removes the one in cargo-miri. The others need logging machinery extensions first, so this is blocked on there being other APIs to control rustc logging. |
All uses of Lines 235 to 238 in d4d85a8
|
saethlin
pushed a commit
to saethlin/rust
that referenced
this issue
Nov 17, 2023
get rid of our last uses of set_var Fixes rust-lang/miri#2783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
set_var
has a problem and there are plans to make it unsafe. So we should find replacements for our uses of it.miri/src/bin/miri.rs
Line 169 in d0fd429
Needs some way to pass this flag to the rustc logging machinery without an env var.
miri/src/bin/miri.rs
Lines 191 to 198 in d0fd429
Needs a way to init rustc logging by giving it the value of the filter expression we want, instead of the name of an env var with the filter.
miri/cargo-miri/src/setup.rs
Line 121 in d0fd429
This one we could already do: find some other way to propagate this information to all parts of the binary, and to all created sub-processes.
The text was updated successfully, but these errors were encountered: