-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc_log: provide a way to init logging based on the values, not names, of the env vars #117814
Conversation
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
The Miri subtree was changed cc @rust-lang/miri |
d61eda3
to
19b5600
Compare
This comment has been minimized.
This comment has been minimized.
19b5600
to
6317583
Compare
This comment has been minimized.
This comment has been minimized.
6317583
to
86e5d36
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (ee85f7f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 674.6s -> 675.537s (0.14%) |
Miri wants to affect how rustc does logging. So far this required setting environment variables before calling
rustc_driver::init_rustc_env_logger
. However,set_var
is a function one should really avoid calling, so this adds the necessary APIs to rustc such that Miri can just pass it the values of all the log-relevant environment variables, rather than having to change the global environment.