-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Advertise completions and inlay hints resolve server capabilities based on the client capabilities #18589
fix: Advertise completions and inlay hints resolve server capabilities based on the client capabilities #18589
Conversation
…ed on the client capabilities.
Head branch was pushed to by a user without write access
6367410
to
4261ac7
Compare
@SomeoneToIgnore Thank you! I have just tested with my client and this pull request resolves the regression I have seen. |
I'm not up to speed with what happened the past weeks wrt to this but does this also need a beta backport? Edit: Actually this seems separate from the other problems I suppose, though backporting that might not be bad eitherway |
So far it seems that most of the completion-related issues were in "rich" editors that were always requiring the I am trying not to do anything extra on this front without the confirmation now, so let me know if you think it's a good idea to backport. |
It wouldn't hurt I'd say, and yes, we'd need to file the changes here on the in-tree version against https://github.com/rust-lang/rust/tree/beta |
Wasn't this disabled on beta in rust-lang/rust#133546? |
Oh, sorry, I'm sick and not thinking straight. |
I'd say not backport if it's not strictly needed, it's fine if it hits stable in the next version. |
Ah okay, then I agree. No need to backport this 👍 |
May I ask if there's any policy regarding when this change will be available through rustup-installed rust-anayzer? |
I think the problematic code was disabled in 1.83. I'll try to do another subtree sync tomorrow, so this should hit nightly in a couple of days. |
No description provided.