Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Revert r-a completions breakage #133546

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

SomeoneToIgnore
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Nov 27, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Nov 27, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 27, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 27, 2024

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@cuviper cuviper changed the title Revert r-a completions breakage [beta] Revert r-a completions breakage Nov 27, 2024
@jieyouxu jieyouxu added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Nov 27, 2024
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

Seems reasonable.

@bors
Copy link
Contributor

bors commented Nov 28, 2024

📌 Commit 8d3b048 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2024
@bors
Copy link
Contributor

bors commented Dec 2, 2024

⌛ Testing commit 8d3b048 with merge ea5e5ca...

@bors
Copy link
Contributor

bors commented Dec 2, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing ea5e5ca to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 2, 2024
@bors bors merged commit ea5e5ca into rust-lang:beta Dec 2, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants