Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make single_range_in_vec_init ignore type annotations, fn arguments and ExprFields #11088

Closed
wants to merge 2 commits into from
Closed

Make single_range_in_vec_init ignore type annotations, fn arguments and ExprFields #11088

wants to merge 2 commits into from

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jul 3, 2023 •
edited
Loading

Closes #11086

This still lints if it's a local and used in a function, as ignoring that would be very hard and very slow, but it now gives a note to give type annotations if this is intended.

changelog: Enhancement: [single_range_in_vec_init]: Ignores if it's a local that has type annotations, or is immediately passed to a function or struct initializer

@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2023

r? @Alexendoo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 3, 2023
@bors
Copy link
Contributor

bors commented Jul 13, 2023

☔ The latest upstream changes (presumably #11095) made this pull request unmergeable. Please resolve the merge conflicts.

@Centri3 Centri3 changed the title Make single_range_in_vec_init ignore type annotations and fn arguments Make single_range_in_vec_init ignore type annotations, fn arguments and ExprFields Jul 16, 2023
@Alexendoo
Copy link
Member

#11166 could be useful here

@bors
Copy link
Contributor

bors commented Aug 11, 2023

☔ The latest upstream changes (presumably #11239) made this pull request unmergeable. Please resolve the merge conflicts.

@Alexendoo
Copy link
Member

#11166 was merged, let's use that here

@Centri3 Centri3 mentioned this pull request Aug 24, 2023
Closed
@Alexendoo Alexendoo added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 31, 2023
@xFrednet
Copy link
Member

Hey this is triage, I'm closing this due to inactivity. Currently, @Centri3 sadly doesn't have the time to continue this implementation. If anyone is interested in continuing this PR, you're more than welcome to create a new PR and push it over the finish line. :D

Thank you to @Centri3 and the reviewers for the time, that you already put into this!

@rustbot label +S-inactive-closed -S-waiting-on-author -S-waiting-on-review

@xFrednet xFrednet closed this Mar 31, 2024
@rustbot rustbot added S-inactive-closed Status: Closed due to inactivity and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Mar 31, 2024
@matzemathics matzemathics mentioned this pull request Apr 1, 2024
Draft
@xFrednet xFrednet removed the S-inactive-closed Status: Closed due to inactivity label Jul 23, 2024
@xFrednet
Copy link
Member

Removing inactive closed in favor of #12611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Alexendoo Alexendoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

single_range_in_vec_init stronger than expected, when type is known
5 participants
@Centri3 @rustbot @bors @Alexendoo @xFrednet