Refactor some of dereference.rs to util functions
#11166
Conversation
|
r? @Manishearth (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
r? @Centri3 |
|
Failed to set assignee to
|
| Callee, | ||
| /// Access of a field. | ||
| FieldAccess(Ident), | ||
| } |
| Deref, | ||
| Reborrow, | ||
| None, | ||
| } |
There was a problem hiding this comment.
| } | |
| } | |
Is juxtaposing the the type and its impl intentional?
There was a problem hiding this comment.
blank_lines_lower_bound (rustfmt) is definitely relevant here. Is it worth the conflicts though? 👀
There was a problem hiding this comment.
Formatting the type and it's impl without a blank line in between is used in other parts of clippy. It's not a consistent thing though.
There was a problem hiding this comment.
Are the multiple impls similarly intentional?
Can I ask how/where you see the extracted code being applied? (Just curious.) |
|
As a short list of recentish things:
|
Jarcho
force-pushed
the
expr_use
branch
2 times, most recently
from
132c828 to
c6cfc2c
Compare
|
Thanks! |
Extract getting an expression's use context and the context's defined type as util functions.
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
I've seen a few lints that need to be able to tell if changing the type of an expression would be a vaild suggestion. This extracts part of how that's done from
explicit_auto_deref.changelog: None