add `trim_split_whitespace` #8575

FoseFx · 2022-03-22T20:32:00Z

Closes #8521

changelog: [trim_split_whitespace]

rust-highfive · 2022-03-22T20:32:04Z

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

clippy_lints/src/strings.rs

tests/ui/trim_split_whitespace.rs

clippy_lints/src/strings.rs

tests/ui/trim_split_whitespace.rs

…, r=flip1995 add diagnostic items for clippy's `trim_split_whitespace` Adding the following diagnostic items: * str_split_whitespace, * str_trim, * str_trim_start, * str_trim_end They are needed for rust-lang/rust-clippy#8575 r? `@flip1995`

flip1995 · 2022-03-25T19:35:11Z

To use the diagnostic items in this PR, you can try to bump the nightly version in the rust-toolchain file to tomorrow 2022-03-26. I think that should work without breaking anything else in Clippy.

(You can only do this once this nightly is released in about 4-7 hours, obviously)

clippy_lints/src/strings.rs

FoseFx · 2022-03-26T09:33:15Z

There is a different test failing on nightly-2022-03-26. I guess I wait until that is sorted out on master?

bors · 2022-03-30T17:12:33Z

☔ The latest upstream changes (presumably #8576) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2022-04-04T07:49:55Z

☔ The latest upstream changes (presumably #8594) made this pull request unmergeable. Please resolve the merge conflicts.

flip1995 · 2022-04-05T13:56:33Z

Blocked on the sync on Thursday

ghost · 2022-04-08T04:58:54Z

Looks like the tests are missing the edge case where the type implements Deref<Target=str> and has it's own split_whitespace but does not have it's own trim.

Otherwise it's looking good. I tested on a bunch of top crates. I found 3 warnings in procfs and fix worked.

---> procfs-0.12.0/src/net.rs:570:27                                  
warning: found call to `str::trim` before `str::split_whitespace`     
   --> src/net.rs:570:27
    |
570 |         let mut split = s.trim().split_whitespace();
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `trim()`: `split_whitespace()`
    |
    = note: requested on the command line with `-W clippy::trim-split-whitespace`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace


---> procfs-0.12.0/src/diskstats.rs:103:26                            
warning: found call to `str::trim` before `str::split_whitespace`     
   --> src/diskstats.rs:103:26
    |
103 |         let mut s = line.trim().split_whitespace();
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `trim()`: `split_whitespace()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace


---> procfs-0.12.0/src/locks.rs:146:26                                
warning: found call to `str::trim` before `str::split_whitespace`     
   --> src/locks.rs:146:26
    |
146 |         let mut s = line.trim().split_whitespace();
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `trim()`: `split_whitespace()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace

bors · 2022-04-14T14:47:55Z

☔ The latest upstream changes (presumably #8626) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2022-04-19T13:04:21Z

☔ The latest upstream changes (presumably #8711) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2022-04-25T17:46:16Z

☔ The latest upstream changes (presumably #8727) made this pull request unmergeable. Please resolve the merge conflicts.

FoseFx · 2022-05-04T10:38:15Z

poke

flip1995

LGTM me overall. Small suggestion on how to improve the suggestion.

clippy_lints/src/strings.rs

tests/ui/trim_split_whitespace.fixed

FoseFx · 2022-05-04T12:49:58Z

👍

flip1995

Thanks! LGTM.

Can you squash the commits? After that, this is ready to get merged.

FoseFx · 2022-05-04T13:15:37Z

Done 👍

flip1995 · 2022-05-04T13:18:43Z

Thanks! Sorry reviews take so long currently...

@bors r+

bors · 2022-05-04T13:18:44Z

📌 Commit fea177f has been approved by flip1995

bors · 2022-05-04T13:31:21Z

⌛ Testing commit fea177f with merge c7a705a...

bors · 2022-05-04T13:45:12Z

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing c7a705a to master...

rust-highfive assigned flip1995 Mar 22, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 22, 2022

FoseFx commented Mar 22, 2022

View reviewed changes

clippy_lints/src/strings.rs Outdated Show resolved Hide resolved

FoseFx commented Mar 24, 2022

View reviewed changes

tests/ui/trim_split_whitespace.rs Show resolved Hide resolved

flip1995 reviewed Mar 24, 2022

View reviewed changes

flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 24, 2022

FoseFx mentioned this pull request Mar 24, 2022

add diagnostic items for clippy's trim_split_whitespace rust-lang/rust#95276

Merged

flip1995 reviewed Mar 25, 2022

View reviewed changes

clippy_lints/src/strings.rs Outdated Show resolved Hide resolved

FoseFx force-pushed the trim_split_whitespace2 branch from d418857 to 10a1ec8 Compare March 30, 2022 18:20

FoseFx force-pushed the trim_split_whitespace2 branch from 10a1ec8 to e4b2285 Compare April 4, 2022 10:35

flip1995 added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Apr 5, 2022

FoseFx force-pushed the trim_split_whitespace2 branch from e4b2285 to 570c34f Compare April 7, 2022 17:03

FoseFx requested a review from flip1995 April 7, 2022 17:14

flip1995 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work labels Apr 7, 2022

FoseFx force-pushed the trim_split_whitespace2 branch 3 times, most recently from 52c6157 to 1216903 Compare April 13, 2022 16:04

FoseFx force-pushed the trim_split_whitespace2 branch from 1216903 to 90308a3 Compare April 14, 2022 15:49

FoseFx force-pushed the trim_split_whitespace2 branch from 90308a3 to 0d692c2 Compare April 19, 2022 18:04

FoseFx force-pushed the trim_split_whitespace2 branch from 98d8b5e to f37ed5d Compare April 25, 2022 18:32

flip1995 reviewed May 4, 2022

View reviewed changes

clippy_lints/src/strings.rs Outdated Show resolved Hide resolved

clippy_lints/src/strings.rs Outdated Show resolved Hide resolved

tests/ui/trim_split_whitespace.fixed Outdated Show resolved Hide resolved

tests/ui/trim_split_whitespace.fixed Outdated Show resolved Hide resolved

flip1995 approved these changes May 4, 2022

View reviewed changes

add trim_split_whitespace

fea177f

FoseFx force-pushed the trim_split_whitespace2 branch from 2b149c2 to fea177f Compare May 4, 2022 13:05

bors merged commit c7a705a into rust-lang:master May 4, 2022

This was referenced May 4, 2022

New lint: single_field_patterns #8157

Closed

New lint no_effect_replace #8754

Merged

introduce rc_clone_in_vec_init lint #8769

Merged

FoseFx deleted the trim_split_whitespace2 branch July 20, 2022 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add `trim_split_whitespace` #8575

add `trim_split_whitespace` #8575

FoseFx commented Mar 22, 2022 •

edited

Loading

rust-highfive commented Mar 22, 2022

flip1995 commented Mar 25, 2022 •

edited

Loading

FoseFx commented Mar 26, 2022

bors commented Mar 30, 2022

bors commented Apr 4, 2022

flip1995 commented Apr 5, 2022

ghost commented Apr 8, 2022

bors commented Apr 14, 2022

bors commented Apr 19, 2022

bors commented Apr 25, 2022

FoseFx commented May 4, 2022

flip1995 left a comment

FoseFx commented May 4, 2022

flip1995 left a comment

FoseFx commented May 4, 2022

flip1995 commented May 4, 2022

bors commented May 4, 2022

bors commented May 4, 2022

bors commented May 4, 2022

add trim_split_whitespace #8575

add trim_split_whitespace #8575

Conversation

FoseFx commented Mar 22, 2022 • edited Loading

rust-highfive commented Mar 22, 2022

flip1995 commented Mar 25, 2022 • edited Loading

FoseFx commented Mar 26, 2022

bors commented Mar 30, 2022

bors commented Apr 4, 2022

flip1995 commented Apr 5, 2022

ghost commented Apr 8, 2022

bors commented Apr 14, 2022

bors commented Apr 19, 2022

bors commented Apr 25, 2022

FoseFx commented May 4, 2022

flip1995 left a comment

Choose a reason for hiding this comment

FoseFx commented May 4, 2022

flip1995 left a comment

Choose a reason for hiding this comment

FoseFx commented May 4, 2022

flip1995 commented May 4, 2022

bors commented May 4, 2022

bors commented May 4, 2022

bors commented May 4, 2022

add `trim_split_whitespace` #8575

add `trim_split_whitespace` #8575

FoseFx commented Mar 22, 2022 •

edited

Loading

flip1995 commented Mar 25, 2022 •

edited

Loading