Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add diagnostic items for clippy's trim_split_whitespace #95276

Merged
merged 1 commit into from
Mar 25, 2022
Merged

add diagnostic items for clippy's trim_split_whitespace #95276

merged 1 commit into from
Mar 25, 2022

Conversation

FoseFx
Copy link
Contributor

@FoseFx FoseFx commented Mar 24, 2022

Adding the following diagnostic items:

  • str_split_whitespace,
  • str_trim,
  • str_trim_start,
  • str_trim_end

They are needed for rust-lang/rust-clippy#8575

r? @flip1995

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 24, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2022
@flip1995
Copy link
Member

Thanks! Naming of those diagnostic items is in accordance with the naming of the diagnostic items in the mem module, so this seems like a good naming for those functions.

@bors r+ rollup

@flip1995
Copy link
Member

@bors r-

Whoops too trigger happy on that r+

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2022
@FoseFx FoseFx force-pushed the clippy_trim_split_whitespace branch from e686ab5 to 64ad96d Compare March 24, 2022 17:19
@flip1995
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 24, 2022

📌 Commit 64ad96d has been approved by flip1995

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 24, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 25, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 25, 2022
@bors
Auto merge of rust-lang#95291 - Dylan-DPC:rollup-vrb4wlw, r=Dylan-DPC
661e8be 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#94391 (Fix ice when error reporting recursion errors)
 - rust-lang#94655 (Clarify which kinds of MIR are allowed during which phases.)
 - rust-lang#95179 (Try to evaluate in try unify and postpone resolution of constants that contain inference variables)
 - rust-lang#95270 (debuginfo: Fix debuginfo for Box<T> where T is unsized.)
 - rust-lang#95276 (add diagnostic items for clippy's `trim_split_whitespace`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3716c42 into rust-lang:master Mar 25, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 25, 2022
@FoseFx FoseFx deleted the clippy_trim_split_whitespace branch March 25, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 left review comments

Assignees

@flip1995 flip1995

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
5 participants
@FoseFx @rust-highfive @flip1995 @bors @rustbot