Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RPITIT work across crates #101630

Closed
compiler-errors opened this issue Sep 9, 2022 · 1 comment · Fixed by #102164
Closed

Make RPITIT work across crates #101630

compiler-errors opened this issue Sep 9, 2022 · 1 comment · Fixed by #102164
Assignees
@compiler-errors
Labels
F-return_position_impl_trait_in_trait `#![feature(return_position_impl_trait_in_trait)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@compiler-errors
Copy link
Member

I'm pretty sure that these don't work cross-crate yet. If they do, then a test addition would at least be helpful.

  1. Serialize and deserialize the results from the compare_predicates_and_trait_impl_trait_tys query like other separate_provide_extern queries.
  2. Add a UI test with an aux-build crate.
@compiler-errors compiler-errors added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. E-help-wanted Call for participation: Help is requested to fix this issue. F-return_position_impl_trait_in_trait `#![feature(return_position_impl_trait_in_trait)]` labels Sep 9, 2022
@compiler-errors
Copy link
Member Author

hold up, claiming this for now as I rework some stuff.

@compiler-errors compiler-errors self-assigned this Sep 9, 2022
@compiler-errors compiler-errors removed the E-help-wanted Call for participation: Help is requested to fix this issue. label Sep 9, 2022
@compiler-errors compiler-errors mentioned this issue Sep 23, 2022
Merged
@bors bors closed this as completed in b3aa499 Sep 30, 2022
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#102164 - compiler-errors:rpitit-foreign, r=Ta…
f37d280 
…KO8Ki

Serialize return-position `impl Trait` in trait hidden values in foreign libraries

Fixes rust-lang#101630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compiler-errors compiler-errors

Labels
F-return_position_impl_trait_in_trait `#![feature(return_position_impl_trait_in_trait)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
1 participant
@compiler-errors