-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize return-position impl Trait
in trait hidden values in foreign libraries
#102164
Conversation
r? @TaKO8Ki (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 2fa31d3 with merge 020d9c82f30a234a7ea9692cf22c2cce47214a3f... |
☀️ Try build successful - checks-actions |
Queued 020d9c82f30a234a7ea9692cf22c2cce47214a3f with parent e7119a0, future comparison URL. |
Finished benchmarking commit (020d9c82f30a234a7ea9692cf22c2cce47214a3f): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Sorry for the late review! @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (b3aa499): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
…KO8Ki Serialize return-position `impl Trait` in trait hidden values in foreign libraries Fixes rust-lang#101630
Fixes #101630