Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core_intrinsics should be marked as an internal feature #115597

Closed
RalfJung opened this issue Sep 6, 2023 · 1 comment · Fixed by #118123
Closed

core_intrinsics should be marked as an internal feature #115597

RalfJung opened this issue Sep 6, 2023 · 1 comment · Fixed by #118123
Assignees
@compiler-errors
Labels
A-stability Area: `#[stable]`, `#[unstable]` etc. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

RalfJung commented Sep 6, 2023

Using the intrinsics feature triggers a warning about this being "internal to the compiler or standard library", but core_intrinsics does not. Clearly core_intrinsics is internal as well, so it should also get the warning.

core_intrinsics is a library feature though, not a language feature -- does the lint support that?

Cc @Nilstrieb
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 6, 2023
@RalfJung
Copy link
Member Author

RalfJung commented Sep 6, 2023

There are a lot of other library features that should probably also get the lint, namely all the ones with the _internals suffix.

@Noratrieb Noratrieb added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. A-stability Area: `#[stable]`, `#[unstable]` etc. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 6, 2023
@compiler-errors compiler-errors self-assigned this Sep 6, 2023
@compiler-errors compiler-errors mentioned this issue Sep 6, 2023
Closed
@RalfJung RalfJung mentioned this issue Nov 21, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 5, 2023
@matthiaskrgr
Rollup merge of rust-lang#118123 - RalfJung:internal-lib-features, r=…
13d386e 
…compiler-errors

Add support for making lib features internal

We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug.

This extends that idea to lib features as well. It is an alternative to rust-lang#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal.

Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang#115597.
compiler-errors added a commit to compiler-errors/rust that referenced this issue Dec 5, 2023
@compiler-errors
Rollup merge of rust-lang#118123 - RalfJung:internal-lib-features, r=…
f366503 
…compiler-errors

Add support for making lib features internal

We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug.

This extends that idea to lib features as well. It is an alternative to rust-lang#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal.

Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang#115597.
compiler-errors added a commit to compiler-errors/rust that referenced this issue Dec 5, 2023
@compiler-errors
Rollup merge of rust-lang#118123 - RalfJung:internal-lib-features, r=…
685d20b 
…compiler-errors

Add support for making lib features internal

We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug.

This extends that idea to lib features as well. It is an alternative to rust-lang#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal.

Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang#115597.
@bors bors closed this as completed in 19bf749 Dec 6, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Dec 6, 2023
@rust-timer
Unrolled build for rust-lang#118123
66e78d8 
Rollup merge of rust-lang#118123 - RalfJung:internal-lib-features, r=compiler-errors

Add support for making lib features internal

We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug.

This extends that idea to lib features as well. It is an alternative to rust-lang#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal.

Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang#115597.
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Dec 12, 2023
@compiler-errors
Rollup merge of #118123 - RalfJung:internal-lib-features, r=compiler-…
76c972c 
…errors

Add support for making lib features internal

We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug.

This extends that idea to lib features as well. It is an alternative to rust-lang/rust#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal.

Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang/rust#115597.
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Apr 7, 2024
@compiler-errors
Rollup merge of #118123 - RalfJung:internal-lib-features, r=compiler-…
dc4c163 
…errors

Add support for making lib features internal

We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug.

This extends that idea to lib features as well. It is an alternative to rust-lang/rust#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal.

Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang/rust#115597.
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 27, 2024
@compiler-errors
Rollup merge of #118123 - RalfJung:internal-lib-features, r=compiler-…
abb3d73 
…errors

Add support for making lib features internal

We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug.

This extends that idea to lib features as well. It is an alternative to rust-lang/rust#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal.

Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang/rust#115597.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compiler-errors compiler-errors

Labels
A-stability Area: `#[stable]`, `#[unstable]` etc. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for making lib features internal RalfJung/rust
4 participants
@RalfJung @compiler-errors @rustbot @Noratrieb