Allow library features to be marked internal as well #115623

compiler-errors · 2023-09-06T23:38:55Z

allows unstable(..., is_internal, ...) to mark a library feature as internal. Not sure if we should just have a different stability attribute, like #[internal(...)] with the same fields as unstable.

Part of #115597.

This does no modification to the standard library yet.

rustbot · 2023-09-06T23:39:03Z

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

compiler-errors · 2023-09-06T23:39:40Z

compiler/rustc_middle/src/query/mod.rs

        desc { "calculating the lib features defined in a crate" }
        separate_provide_extern
+        arena_cache
    }


I consolidated this into one query -- it's not necessarily a requirement of this PR to do so, so if that's not desirable, I could revert it.

This is useful. Could you extract it in a standalone query? Or even a standalone PR, as there may be discussion on this PR.

petrochenkov · 2023-09-07T03:16:31Z

Double-gating internal features was a mistake by itself, and now other unnecessary complexity is accumulating around that mistake.

cjgillot · 2023-09-07T17:35:48Z

compiler/rustc_passes/src/stability.rs

@@ -1027,7 +1030,7 @@ pub fn check_unused_or_stable_features(tcx: TyCtxt<'_>) {

    // We always collect the lib features declared in the current crate, even if there are
    // no unknown features, because the collection also does feature attribute validation.
-    let local_defined_features = tcx.lib_features(()).to_vec();
+    let local_defined_features = tcx.lib_features(rustc_hir::def_id::LOCAL_CRATE);


Please import this.

cjgillot · 2023-09-07T17:36:50Z

compiler/rustc_middle/src/query/mod.rs

        desc { "calculating the lib features defined in a crate" }
        separate_provide_extern
+        arena_cache
    }


This is useful. Could you extract it in a standalone query? Or even a standalone PR, as there may be discussion on this PR.

cjgillot · 2023-09-07T17:38:32Z

compiler/rustc_lint/src/builtin.rs

+                    }
+                }
+            }
+        }


Should all this method go in rustc_passes::stability::check_unused_or_stable_features?

RalfJung · 2023-09-23T05:37:12Z

I was thinking we could do this a lot simpler, and just trigger the lint for all features whose name ends in _internal or _internals. That should also work pretty well, shouldn't it? We'll have to rename core_intrinsics to core_intrinsics_internal, but other than that I think the internal library features already follow this convention.

compiler-errors · 2023-09-23T05:40:16Z

I kinda prefer the more general solution, but yeah, I'm happy doing it that way too.

bors · 2023-09-28T22:23:52Z

☔ The latest upstream changes (presumably #116199) made this pull request unmergeable. Please resolve the merge conflicts.

…gillot Unify `defined_lib_features` and `lib_features` queries Extracts part of rust-lang#115623 (comment) I went with also introducing a `FeatureStability` enum, instead of using `Some(span)` to mean stable and `None` to mean unstable. r? `@cjgillot`

…compiler-errors Add support for making lib features internal We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug. This extends that idea to lib features as well. It is an alternative to rust-lang#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal. Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang#115597.

Rollup merge of rust-lang#118123 - RalfJung:internal-lib-features, r=compiler-errors Add support for making lib features internal We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug. This extends that idea to lib features as well. It is an alternative to rust-lang#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal. Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang#115597.

…errors Add support for making lib features internal We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug. This extends that idea to lib features as well. It is an alternative to rust-lang/rust#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal. Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang/rust#115597.

Allow library features to be marked internal as well

0a4e187

rustbot assigned cjgillot Sep 6, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 6, 2023

compiler-errors commented Sep 6, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

Split early and late internal feature lint

1da0c89

cjgillot reviewed Sep 7, 2023

View reviewed changes

cjgillot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2023

compiler-errors mentioned this pull request Sep 23, 2023

Unify defined_lib_features and lib_features queries #116092

Merged

compiler-errors closed this Nov 17, 2023

RalfJung mentioned this pull request Nov 21, 2023

Add support for making lib features internal #118123

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow library features to be marked internal as well #115623

Allow library features to be marked internal as well #115623

compiler-errors commented Sep 6, 2023

rustbot commented Sep 6, 2023

compiler-errors Sep 6, 2023

cjgillot Sep 7, 2023

This comment has been minimized.

petrochenkov commented Sep 7, 2023

cjgillot Sep 7, 2023

cjgillot Sep 7, 2023

cjgillot Sep 7, 2023

RalfJung commented Sep 23, 2023

compiler-errors commented Sep 23, 2023

bors commented Sep 28, 2023

Allow library features to be marked internal as well #115623

Allow library features to be marked internal as well #115623

Conversation

compiler-errors commented Sep 6, 2023

rustbot commented Sep 6, 2023

compiler-errors Sep 6, 2023

Choose a reason for hiding this comment

cjgillot Sep 7, 2023

Choose a reason for hiding this comment

This comment has been minimized.

petrochenkov commented Sep 7, 2023

cjgillot Sep 7, 2023

Choose a reason for hiding this comment

cjgillot Sep 7, 2023

Choose a reason for hiding this comment

cjgillot Sep 7, 2023

Choose a reason for hiding this comment

RalfJung commented Sep 23, 2023

compiler-errors commented Sep 23, 2023

bors commented Sep 28, 2023