Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

one of the io doc tests fails if port 8080 is already bound to #11576

Closed
nickdesaulniers opened this issue Jan 15, 2014 · 1 comment
Closed

one of the io doc tests fails if port 8080 is already bound to #11576

nickdesaulniers opened this issue Jan 15, 2014 · 1 comment

Comments

@nickdesaulniers
Copy link

@alexcrichton helped me find this the hard way. was running vlc by accident. this test

The test is a should fail, but doesn't since another process is listening on the port.
@alexcrichton
Copy link
Member

The test should probably just fail!() immediately. We just want to compile it make sure the syntax/types are valid.

huonw added a commit to huonw/rust that referenced this issue Jun 9, 2014
@huonw
std: adjust the TCP io doc example to work reliably.
26cfc43 
Fixes rust-lang#11576 by making the code never run (and hence never
pass when the test was marked `should_fail`).
@huonw huonw closed this as completed in 14668f2 Jun 10, 2014
mcpherrinm pushed a commit to mcpherrinm/rust that referenced this issue Jun 10, 2014
@huonw @mcpherrinm
std: adjust the TCP io doc example to work reliably.
48eaa14 
Fixes rust-lang#11576 by making the code never run (and hence never
pass when the test was marked `should_fail`).
flip1995 pushed a commit to flip1995/rust that referenced this issue Sep 28, 2023
@bors
Auto merge of rust-lang#11576 - koka831:fix/10128, r=llogiq
d18d01a 
write_literal: Fix index of the remaining positional arguments

- fixes rust-lang/rust-clippy#10128
- `clippy --fix` replaces multiple warnings at once
   e.g.)
   ```rust
   writeln!(v, "{0} {1}", "hello", "world");
   // before: `writeln!(v, "hello {1}", "world");`
   // now: `writeln!(v, "hello world");`
   ```

changelog: [`print_literal`], [`write_literal`]: Now handles positional argument properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @nickdesaulniers